After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697255 - "Save password" shows in unrelated web apps
"Save password" shows in unrelated web apps
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 697115 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-04 11:38 UTC by Bastien Nocera
Modified: 2013-04-05 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
twitter webapp (812.42 KB, image/png)
2013-04-04 11:38 UTC, Bastien Nocera 		  Details
Patch (1.41 KB, patch)
2013-04-04 16:41 UTC, Carlos Garcia Campos 		committed Details | Review

Description Bastien Nocera 2013-04-04 11:38:42 UTC 
Created attachment 240583 [details]
twitter webapp

gnome-keyring-3.8.0-1.fc19.x86_64
libsecret-0.15-1.fc19.x86_64
epiphany-3.8.0-1.fc19.x86_64

I have separate webapps for Facebook and Twitter, and use Epiphany as my main browser.

When I logged into Facebook today, it asked me whether I wanted to save the password, not in just the Facebook webapp, but also in the Twitter app and hidden in a tab in my main browser instance.

Could this be a case of badly filtered signal from gnome-keyring?
Comment 1 Carlos Garcia Campos 2013-04-04 13:12:34 UTC 
Looks like a badly filtered D-Bus signal emitted by our web extension. I'll look at it.
Comment 2 Carlos Garcia Campos 2013-04-04 16:41:58 UTC 
Created attachment 240639 [details] [review]
Patch

Bastien, could you confirm this patch fixes the problem for you?
Comment 3 Bastien Nocera 2013-04-05 09:09:13 UTC 
I can't seem to get any "save password" clue bar to show up with this patch.

Why not send the signal with the shell's dbus name as the destination instead?
Comment 4 Bastien Nocera 2013-04-05 09:53:42 UTC 
Works with the second patch from bug 696020.
Comment 5 Xan Lopez 2013-04-05 16:39:46 UTC 
*** Bug 697115 has been marked as a duplicate of this bug. ***
Comment 6 Xan Lopez 2013-04-05 16:41:33 UTC 
Review of attachment 240639 [details] [review]:

Makes sense, push to both branches please.
Comment 7 Carlos Garcia Campos 2013-04-05 16:59:13 UTC 
Comment on attachment 240639 [details] [review]
Patch

Pushed to both branches. Thanks for you help testing it.