Bug 697251 - file browser: Alt+Home should jump to home directory
file browser: Alt+Home should jump to home directory
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: plugins
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Gedit maintainers
Gedit maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-04-04 10:46 UTC by Adam Dingle
Modified: 2013-06-14 18:52 UTC (History)
3 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Alt+Home should go to home directory (4.14 KB, patch)
2013-06-14 13:35 UTC, Garrett Regier 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Adam Dingle 2013-04-04 10:46:04 UTC 
It would be convenient if I could press Alt+Home in the file browser pane to jump to my home directory, just like in Nautilus.
Comment 1 Garrett Regier 2013-06-14 13:35:03 UTC 
Created attachment 246807 [details] [review]
Alt+Home should go to home directory
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-06-14 13:37:59 UTC 
Review of attachment 246807 [details] [review]:

Minor comment, feel free to push it apart from it.

::: plugins/filebrowser/gedit-file-browser-widget.c
@@ +2717,3 @@
+	model = gtk_tree_view_get_model (GTK_TREE_VIEW (widget->priv->treeview));
+
+	if (!GEDIT_IS_FILE_BROWSER_STORE (model))

missing {}
Comment 3 Garrett Regier 2013-06-14 15:35:27 UTC 
That is the current style of code it that file, should I still change it?


(In reply to comment #2)
> Review of attachment 246807 [details] [review]:
> 
> Minor comment, feel free to push it apart from it.
> 
> ::: plugins/filebrowser/gedit-file-browser-widget.c
> @@ +2717,3 @@
> +    model = gtk_tree_view_get_model (GTK_TREE_VIEW (widget->priv->treeview));
> +
> +    if (!GEDIT_IS_FILE_BROWSER_STORE (model))
> 
> missing {}
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-06-14 15:38:19 UTC 
ok then, push it as it is and if you feel bored you can change the coding style of the file in a different commit.
Comment 5 Garrett Regier 2013-06-14 15:41:55 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Note You need to log in before you can comment on or make changes to this bug.