After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697232 - vp8dec reports decoding errors as "No key frame" giving no extra information
vp8dec reports decoding errors as "No key frame" giving no extra information
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.5
Other Mac OS
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-03 23:03 UTC by tcdgreenwood
Modified: 2013-04-10 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for improving debugging (1.13 KB, patch)
2013-04-03 23:03 UTC, tcdgreenwood 		none Details | Review
Patch for improving debugging (1.12 KB, patch)
2013-04-03 23:10 UTC, tcdgreenwood 		committed Details | Review

Description tcdgreenwood 2013-04-03 23:03:50 UTC 
Created attachment 240559 [details] [review]
Patch for improving debugging

Invalid data is reported as "No key frame", this is fine if it's valid VP8, but if it's not it would be good to report information from libvpx.
Comment 1 tcdgreenwood 2013-04-03 23:10:22 UTC 
Created attachment 240560 [details] [review]
Patch for improving debugging
Comment 2 Tim-Philipp Müller 2013-04-04 09:19:29 UTC 
Shouldn't it be

 else if (!stream_info.is_kf)

?

Also, could you please run

 git config --global user.email "tcdgreenwood@hotmail.com"

so your patches don't have "Tom Greenwood <tgreenwood@Toms-MacBook-Pro.local>" as author.
Comment 3 Sebastian Dröge (slomo) 2013-04-04 09:49:59 UTC 
commit 3d335cb1ed23b5a35c22277d29575a929ef942ad
Author: Tom Greenwood <tgreenwood@Toms-MacBook-Pro.local>
Date:   Wed Apr 3 23:52:47 2013 +0100

    vp8dec: Improve logging when vpx_codec_peek_stream_info fails
    
    Decode failures and missing keyframes should get different debug
    output.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697232
Comment 4 tcdgreenwood 2013-04-10 17:57:54 UTC 
I will change my address.  

I didn't think the else if mattered as both paths should always return - happy to change to else if if that is better from your coding style POV.