After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697223 - lib: Add GeocodeIpclient:compatibility-mode property
lib: Add GeocodeIpclient:compatibility-mode property
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-03 20:53 UTC by Zeeshan Ali
Modified: 2013-04-04 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lib: Add GeocodeIpclient:compatibility-mode property (4.52 KB, patch)
2013-04-03 20:53 UTC, Zeeshan Ali 		needs-work Details | Review
lib: Add GeocodeIpclient:compatibility-mode property (4.67 KB, patch)
2013-04-04 13:40 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2013-04-03 20:53:31 UTC 
See patch.
Comment 1 Zeeshan Ali 2013-04-03 20:53:33 UTC 
Created attachment 240543 [details] [review]
lib: Add GeocodeIpclient:compatibility-mode property

App must enable this mode if they want to use freegeoip's (or a
compatible) service.
Comment 2 Bastien Nocera 2013-04-04 05:59:40 UTC 
Review of attachment 240543 [details] [review]:

::: geocode-glib/geocode-ipclient.c
@@ +215,3 @@
+                        uri = g_strdup_printf ("%s/%s",
+                                               ipclient->priv->server,
+                                               ipaddress);

You need to escape this.
Comment 3 Zeeshan Ali 2013-04-04 13:40:53 UTC 
Created attachment 240607 [details] [review]
lib: Add GeocodeIpclient:compatibility-mode property

v2: Escape IP address.
Comment 4 Bastien Nocera 2013-04-04 14:50:24 UTC 
Review of attachment 240607 [details] [review]:

Looks good.
Comment 5 Zeeshan Ali 2013-04-04 19:33:31 UTC 
Attachment 240607 [details] pushed as 05b0009 - lib: Add GeocodeIpclient:compatibility-mode property