After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697160 - [PATCH] gmacros: Mark G_UNAVAILABLE() functions as deprecated (gcc <= 4.4)
[PATCH] gmacros: Mark G_UNAVAILABLE() functions as deprecated (gcc <= 4.4)
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-04-03 04:33 UTC by Colin Walters
Modified: 2013-04-03 04:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-gmacros-Mark-G_UNAVAILABLE-functions-as-deprecated-g.patch (1.10 KB, patch)
2013-04-03 04:34 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Colin Walters 2013-04-03 04:33:34 UTC 
RHEL6 ships with GCC 4.4 by default, which doesn't understand the
nicer deprecated attribute that takes a message.  However, we can at
least fall back to the old G_DEPRECATED, rather than silently doing
nothing.

This gives me warning messages when building OSTree on RHEL6 when I
accidentally added a usage of g_unix_fd_source_new().
---
 glib/gmacros.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 1 Colin Walters 2013-04-03 04:34:07 UTC 
Created attachment 240462 [details] [review]
0001-gmacros-Mark-G_UNAVAILABLE-functions-as-deprecated-g.patch
Comment 2 Allison Karlitskaya (desrt) 2013-04-03 04:40:00 UTC 
Review of attachment 240462 [details] [review]:

assuming G_DEPRECATED is working then this will also obviously work, so ACK
Comment 3 Colin Walters 2013-04-03 04:43:36 UTC 
Thanks for the fast review!