Created attachment 240648 [details] [review]
window-list: Add support for AUTO grouping

In addition to "always" and "never", gnome-panel supported an "auto"
grouping mode, which only started to group items when running out of
available space. It makes sense for us to support the same option in
the window-list extension, so implement it.

I wonder if we should default to 'auto' (though the current default of 'never' matches gnome-panel) ...

Review of attachment 240648 [details] [review]:

::: extensions/window-list/extension.js
@@ +445,3 @@
+                if (width < natWidth) {
+                    this._grouped = true;
+                    this._populateWindowList();

Unfortunately, this causes an allocation cycle. Defer it to and idle?

Review of attachment 240648 [details] [review]:

according to rui's review

Created attachment 241661 [details] [review]
window-list: Add support for AUTO grouping

Just out of curiousity - were the "allocation cycle" warnings removed at some point? I didn't get any warnings with the previous patch either, but deferring to a MetaLater handler doesn't hurt, so ...

Review of attachment 241661 [details] [review]:

(In reply to comment #5)
> Just out of curiousity - were the "allocation cycle" warnings removed at some
> point? I didn't get any warnings with the previous patch either, but deferring
> to a MetaLater handler doesn't hurt, so ...

I see the warnings when going ungrouped → grouped.

Deferring makes us show one wrong frame though but still seems better than the warnings.

(In reply to comment #6)
> I see the warnings when going ungrouped → grouped.

Odd, no warnings in that case here (or the opposite grouped → ungrouped case) ...

Attachment 241661 [details] pushed as 360ba43 - window-list: Add support for AUTO grouping

In any case, I don't think the one-frame-delay is that bad, so pushing for 3.8.1 ...