Created attachment 240450 [details] [review]
Add a test token for classic mode

Review of attachment 240450 [details] [review]:

::: libyelp/yelp-settings.c
@@ +309,3 @@
+            GVariant *v;
+            g_variant_get (ret, "(v)", &v);
+            g_variant_get (v, "&s", &name);

this is unsafe.  you don't know what's inside of the "v" and it may not be a string, making this a programmer error.

the use of a char* to store the return of "&s" is also a technical (if not pedantic) type error.

do it like

if (g_variant_is_of_type (v, G_VARIANT_TYPE_STRING) &&
    g_str_equal (g_variant_get_string (v, NULL), "classic"))

or something like that

I'd rather have the word "gnome" in the test token. platform:gnome-classic perhaps. And I trust desrt's nitpicks about the GVariant use. Other than that, if you don't think it's too much for 3.8.1, this is cool.

Created attachment 240779 [details] [review]
Add a test token for classic mode

The test token is called platform:gnome-classic.
This will be used to adjust the GNOME user guide for classic mode
in a few places.

Attachment 240450 [details] pushed as ef92b1f - Add a test token for classic mode
Attachment 240779 [details] pushed as ef92b1f - Add a test token for classic mode