GNOME Bugzilla – Bug 697124
what are workspaces needs an update
Last modified: 2014-01-26 22:18:15 UTC
the screenshot of the workspace switcher there has the search entry in the wrong place. should be replaced by a newer screenshot.
Created attachment 240824 [details] [review] Updated shell-workspaces.page I haven't removed the old screenshot yet. Also, haven't pushed to master. Waiting for a review. :)
I think you should retain the file name "shell-workspaces", it's more appropriate and just update the screenshots.
I don't intend to change the name of the page.(And I haven't :) ) As of now, I have added a screenshot called shell-workspaces-new.png. If it's reviewed to be okay, I can change the name to shell-workspaces.png, delete the old shell-workspaces.png and make all necessary changes to the Makefile. Thanks for looking at the patch. :)
Review of attachment 240824 [details] [review]: Firstly, replace the old image with the new one without renaming it (as Sindhu said), so that the old image is no longer there. Secondly, that image is currently so tiny that it's a bit useless. Either think of a way to increase the size until it is readable without making it take up any more height or use experimental UI extensions[1] alongside a full sized image so that a clickable thumbnail is shown to the user. [1] see https://git.gnome.org/browse/gnome-getting-started-docs/tree/gnome-help/C/getting-started.page for example on how to use it
Hi Aruna, are you still interested in working on this bug?
Hey Kat, I have been working on this bug actually. I did some work on it with Petr, at GUADEC, as well. While we have a thumbnail that, on clicking, is enlarged, we weren't able to display this thumbnail on the right side of the page, when rendered on yelp. Right now, it gets rendered right below the title on the centre and I am not sure if there's a means to render it on the right, and have the text fill around it. If someone clarifies, I can submit a patch almost immediately.
Created attachment 259032 [details] [review] Overlay-element-used-to-enclose-the-screenshot Screenshot used is of poor quality since it was only used for testing. I can update it once you finish testing to check if floatend floatright works on the style.
I've not been able to make it work properly, so could you please update the screenshot for now so that it's done for the 3.10.2 release and we can figure out what to do about making the screenshot useful after the release…
Created attachment 259309 [details] [review] Screenshot, with overlay element Hey Kat, you didn't specify whether we should keep the screenshot with the overlay(Where the thumbnail is in the middle of the page), or the other one, so I am attaching patches to both. I think the one without the overlay would be more suitable, though.
Created attachment 259310 [details] [review] Screenshot without overlay element This screenshot does not use the experimental UI namespace, and uses the regular media element for the screenshot.
Created attachment 259311 [details] [review] Screenshot without overlay element Screenshot without overlay element. It does not use the experimental UI namespace and uses a regular <media> element for the screenshot. (Updated the wrong patch last time. ;) )
Review of attachment 259311 [details] [review]: Publish. Should the bug be marked as RESOLVED/FIXED? I am not sure because we want to ultimately work on the overlay right?
Previous patch did not include an updated screenshot, it seems. Fixed by https://git.gnome.org/browse/gnome-user-docs/commit/?id=5b8b9781a85fcb74a148898d18782537b72c2107 and https://git.gnome.org/browse/gnome-user-docs/commit/?id=5430700e754c807b3e7ecd459e1c30b0e3de47c6