GNOME Bugzilla – Bug 697121
notifications and message tray - missing image
Last modified: 2013-05-19 21:33:07 UTC
The second image on that page is missing.
<img src="figures/notification-buttons.png">
Created attachment 240836 [details] [review] Screenshot for message tray Added a screenshot and deleted mimico's comment about the same. Does the screenshot clarify the position of the message tray? Please let me know so I can update the screenshot if it doesn't. Thanks!
Review of attachment 240836 [details] [review]: Hey, this patch doesn't apply because you patched something else in the same file in patch 1/2. In future, please avoid conflicts like this by creating a patch just of this one commit. Regarding the image, please use the Aidwaita theme when taking the screenshot. You should also include some of the default background above the message tray (so that it's slightly more obvious that it is at the bottom of the screen). You should also crop out most of the blank area of the screenshot as it's not useful, but do leave enough in so that it looks like the icons are right-aligned! ::: gnome-help/Makefile.am @@ +40,3 @@ figures/input-methods-switcher.png \ figures/keyboard-key-menu.svg \ + figures/message-tray.png \ Stick to the naming scheme for images. You should use something along the lines of "shell-message-tray.png"
Created attachment 241736 [details] mesage-tray-nautilus.png Thanks for the review Kat. :) Can you see if this image is okay? I'm not able to choose the right background for the image. I'll upload a couple here, so you can choose the one that best describes the message tray. This one has nautilus as the backdrop
Created attachment 241737 [details] message-tray-impress.png This one has impress as the backdrop.
Created attachment 241738 [details] message-tray-firefox.png Has firefox find box in the image. Here the image has been scaled down because the backdrop is to its left.
Created attachment 241746 [details] [review] Patch with new image and corrected changes. Added a new image. Sorry about the commit conflict. This one's alright. Thanks.
The patch doesn't seem to apply to current master. Aruna, could you please look at it so that we can distribute this update with 3.8.2? Thanks!
Created attachment 244406 [details] [review] New patch Sorry for being so late Petr! There was a commit conflict which I've fixed. Could you please see if this applies and review it? Thank you very much. :)
Oops, think I missed the release by a day.
(In reply to comment #10) > Oops, think I missed the release by a day. I think we could have a .3 stable release soon. The patch looks good to me, I would only change the position of the image, eg.: <media type="image" src="figures/shell-message-tray.png" width="344" height="50" style="floatend floatright">
Created attachment 244428 [details] [review] Made suggested changes, changed commit message I've made the change. Now it looks more compliant with the positions of the screenshots in that page. Thank you. Can I push this to master?
Review of attachment 244428 [details] [review]: Looks good, please push to master. Thank you.
Review of attachment 244428 [details] [review]: Thank you Petr. I have pushed this to master with commit ID 2fa8e5694fb5bbe990b3be713b7361f63f45d20c.