Bug 697118 – "Unknown error" dialog when installing an already installed package

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 697118 - "Unknown error" dialog when installing an already installed package


Summary:	"Unknown error" dialog when installing an already installed package


Status:	RESOLVED FIXED

Product:	gnome-packagekit
Classification:	Core
Component:	general
Version:	3.8.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gnome-packagekit-maint
QA Contact:	gnome-packagekit-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-04-02 16:12 UTC by Cosimo Cecchi
Modified:	2013-04-11 11:45 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
screenshot (18.10 KB, image/png) 2013-04-02 16:12 UTC, Cosimo Cecchi	Details

Description Cosimo Cecchi 2013-04-02 16:12:07 UTC

I tried to install an RPM file that I already had installed on my machine.
PackageKit obviously failed to do so, but the error dialog we show in that case is quite confusing.
- the dialog seems to be a generic "unknown error" template, but the error is actually known: the package is already installed.
- it talks about a distribution bug tracker without giving any hint on what that might be or how to locate it. It also shouldn't mention that at all in this case, since the error doesn't have anything to do with the distribution.
- the detailed report is not very detailed - it's actually shorter than the dialog explanation string itself.

Comment 1 Cosimo Cecchi 2013-04-02 16:12:20 UTC

Created attachment 240403 [details]
screenshot

Comment 2 Richard Hughes 2013-04-11 09:22:51 UTC

PK does the right than and emits: "emitting error-code package-already-installed" so it's just an error in the front-end. I'll fix this now.

Comment 3 Richard Hughes 2013-04-11 11:45:09 UTC

commit f341c65a7967c1a8c276cdfc4e66cf2c9a20c171
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Apr 11 12:42:21 2013 +0100

    Do not try and duplicate all the PackageKit errors in the session helper
    
    GpkDbusError was just a subset of PkError enumerated values which made it
    impossible to properly translate the various error codes properly.
    Just register all the PkErrorEnum enums and get rid of the GpkDbusError
    abstraction completely.
    
    Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=697118

:100644 100644 2c2b786... 0bdb871... M  src/gpk-dbus-task.c
:100644 100644 3f84725... 6aab531... M  src/gpk-dbus.c
:100644 100644 6949dea... f32b990... M  src/gpk-dbus.h

commit c627554a91a044991700dcf28b25f54eaa6d383f
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Apr 11 12:30:56 2013 +0100

    Never show two modal dialog boxes when using the install helpers

:100644 100644 81add1b... fbc01e0... M  src/gpk-common.c
:100644 100644 d50ee3b... f762d92... M  src/gpk-common.h
:100644 100644 7e73f66... f4e30c6... M  src/gpk-install-catalog.c
:100644 100644 3301056... 73826a6... M  src/gpk-install-local-file.c
:100644 100644 1c5a15e... 0a9c66c... M  src/gpk-install-mime-type.c
:100644 100644 4ca2442... 415c207... M  src/gpk-install-package-name.c
:100644 100644 ac9d2e7... d687cf9... M  src/gpk-install-provide-file.c