After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697076 - Cleanup #includes, second round
Cleanup #includes, second round
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-01 21:41 UTC by Emanuele Aina
Modified: 2013-04-02 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reorder header inclusions accordingly to the Telepathy coding style (111.85 KB, patch)
2013-04-01 21:41 UTC, Emanuele Aina 		committed Details | Review
Clean up #include directives in headers (25.62 KB, patch)
2013-04-01 21:41 UTC, Emanuele Aina 		committed Details | Review
Clean up #include directives in source files (28.76 KB, patch)
2013-04-01 21:41 UTC, Emanuele Aina 		committed Details | Review
Clean up #include directives in source files (28.76 KB, patch)
2013-04-02 09:28 UTC, Emanuele Aina 		committed Details | Review
Clean up #include directives in headers (25.62 KB, patch)
2013-04-02 09:28 UTC, Emanuele Aina 		committed Details | Review
Reorder header inclusions accordingly to the Telepathy coding style (111.85 KB, patch)
2013-04-02 09:28 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-04-01 21:41:16 UTC 
Sort #includes accordingly to the Telepathy coding style and then drop a few
redundant ones
Comment 1 Emanuele Aina 2013-04-01 21:41:22 UTC 
Created attachment 240333 [details] [review]
Reorder header inclusions accordingly to the Telepathy coding style

Sort by:
• "config.h"
• API declarations, if any
• public libraries
• internal headers, alphabetically sorted (mostly)

http://telepathy.freedesktop.org/wiki/Style#A.23includes
Comment 2 Emanuele Aina 2013-04-01 21:41:33 UTC 
Created attachment 240334 [details] [review]
Clean up #include directives in headers

Reorder some inclusions and remove a few blank lines.
Comment 3 Emanuele Aina 2013-04-01 21:41:42 UTC 
Created attachment 240335 [details] [review]
Clean up #include directives in source files
Comment 4 Guillaume Desmottes 2013-04-02 09:15:44 UTC 
Review of attachment 240333 [details] [review]:

++
Comment 5 Guillaume Desmottes 2013-04-02 09:16:04 UTC 
Review of attachment 240334 [details] [review]:

++
Comment 6 Guillaume Desmottes 2013-04-02 09:16:20 UTC 
Review of attachment 240334 [details] [review]:

++
Comment 7 Guillaume Desmottes 2013-04-02 09:16:37 UTC 
Review of attachment 240335 [details] [review]:

++
Comment 8 Emanuele Aina 2013-04-02 09:28:04 UTC 
The following fixes have been pushed:
0ad138f Clean up #include directives in source files
b25bcd6 Clean up #include directives in headers
0d137b7 Reorder header inclusions accordingly to the Telepathy coding style
Comment 9 Emanuele Aina 2013-04-02 09:28:30 UTC 
Created attachment 240364 [details] [review]
Clean up #include directives in source files
Comment 10 Emanuele Aina 2013-04-02 09:28:37 UTC 
Created attachment 240365 [details] [review]
Clean up #include directives in headers

Reorder some inclusions and remove a few blank lines.
Comment 11 Emanuele Aina 2013-04-02 09:28:47 UTC 
Created attachment 240366 [details] [review]
Reorder header inclusions accordingly to the Telepathy coding style

Sort by:
• "config.h"
• API declarations, if any
• public libraries
• internal headers, alphabetically sorted (mostly)

http://telepathy.freedesktop.org/wiki/Style#A.23includes