GNOME Bugzilla – Bug 697006
open-tran plugin breaks gtranslator
Last modified: 2017-01-23 18:10:18 UTC
Seems that open-tran.eu is down and if you try to do a search with the plugin it crashes gtranslator. It would be nice if instead of that, it just displays something telling the user that open-tran isn't reachable or the likes.
(gtranslator:17137): Gtk-WARNING **: Theme parsing error: <data>:2:10: Not using units is deprecated. Assuming 'px'. (gtranslator:17137): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed (gtranslator:17137): Json-CRITICAL **: json_node_get_array: assertion `node != NULL' failed Segmentation fault This is a gtranslator build from sources (some weeks ago)
Thanks for taking the time to report this bug. Without a stack trace from the crash it's very hard to determine what caused it. Can you get us a stack trace? Please see http://live.gnome.org/GettingTraces for more information on how to do so. Thanks in advance!
Created attachment 243272 [details] Traces obtained with gdb.
I'm not the original poster, but I notice this issue while testing translations. So here is the output I've got with gdb. Hope it helps.
OpenTran closed in Dec 01 2013, as decided by its maintainer [1]. This plug-in should probably be disabled in plugins/Makefile.am or completely removed. [1] https://groups.google.com/d/msg/open-tran/gO_c6ScjMUk/MEGZNc6hSBUJ
Created attachment 272506 [details] [review] Remove OpenTran plugin Would this patch be enough or should I take in account anything more?
Compilation fails for me, so I can't be sure. But it looks good as there is no other occurrence of open-tran, except for PO files and documentation. By the way, the removal of this plugin should reflect in the documentation too. Can we do this in this very same bug report? # C/gtr-quickstart.page <item> <p>Extend the core features with plugins for version control, viewing the source code, connecting to Open Tran and others.</p> </item> </list> # C/gtr-plugins.page <p><em>Open Tran</em></p> <p>Look for phrases in the <link xref="http://open-tran.eu/">Open Tran</link> translation database.</p> Image: C/figures/gtranslator-plugins.png
It seems that compilation is broken upstream, because I've tried to compile a fresh copy from git and it fails... Anyway, yes: once approved the previous patch, we should modify documentation to remove references to this plugin, but it's something trivial to do. Thanks for pointing it out!
Please just go ahead and remove the plugin. There's no use keeping it around. The patch needs a bit of an update but at least here compilation works with master.
Created attachment 342131 [details] [review] Patch to remove open-tran plugin on master Removes the open-tran plugin on master.
Created attachment 342132 [details] [review] Patch to remove open-tran plugin on gtranslator-2-91 branch Removes the open-tran plugin on the branch 'gtranslator-2-91'. I have tested build and installation on both branches after applying the corresponding patches, and I would like to push them if they are approved.
gtranslator-2-91 is actually a maintenance branch and nothing should be committed to it except for translation updates and important bug fixes. I don't think this qualifies, nor it's worth the trouble, so let's just focus on master for now.
Comment on attachment 342132 [details] [review] Patch to remove open-tran plugin on gtranslator-2-91 branch Marking as rejecting since we're focusing on master.
Review of attachment 342131 [details] [review]: Looks good overall. Help still mentions the plugin though. Can you cook a followup patch to remove the mention?
(In reply to Alexandre Franke from comment #12) > gtranslator-2-91 is actually a maintenance branch and nothing should be > committed to it except for translation updates and important bug fixes. I > don't think this qualifies, nor it's worth the trouble, so let's just focus > on master for now. I am confused about focusing on master. Currently what you get when you compile and install master is just a "Projects" window, which is not functional at all except the x (close) button at the top-right corner of the window. On the other hand, 2.91 branch is actually functional, and has something to work on and improve. (In reply to Alexandre Franke from comment #13) > Comment on attachment 342132 [details] [review] [review] > Patch to remove open-tran plugin on gtranslator-2-91 branch > > Marking as rejecting since we're focusing on master. Please note that 2-91 branch is currently not compiling without this patch. (In reply to Alexandre Franke from comment #14) > Review of attachment 342131 [details] [review] [review]: > > Looks good overall. Help still mentions the plugin though. Can you cook a > followup patch to remove the mention? Great! Sure, the follow-up patch is on the way. :)
Created attachment 342348 [details] Gtranslator master screenshot
Review of attachment 342131 [details] [review]: Committed.
Created attachment 342354 [details] [review] Patch to remove references to OpenTran in documentation (master)
Review of attachment 342354 [details] [review]: LGTM.
Review of attachment 342354 [details] [review]: Committed.
(In reply to Alexandre Franke from comment #19) > Review of attachment 342354 [details] [review] [review]: > > LGTM. Thanks for the review! :) This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.