After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696978 - Embed account widgets .ui files with GResource
Embed account widgets .ui files with GResource
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-31 15:33 UTC by Emanuele Aina
Modified: 2013-04-01 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui-utils: Add empathy_builder_get_resource() (3.20 KB, patch)
2013-03-31 15:33 UTC, Emanuele Aina 		committed Details | Review
account-widget: Embed .ui files with GResource (15.44 KB, patch)
2013-03-31 15:34 UTC, Emanuele Aina 		reviewed Details | Review
account-widget: Embed .ui files with GResource (15.55 KB, patch)
2013-04-01 09:06 UTC, Emanuele Aina 		committed Details | Review
account-widget: Embed .ui files with GResource (15.57 KB, patch)
2013-04-01 10:28 UTC, Emanuele Aina 		committed Details | Review
ui-utils: Add empathy_builder_get_resource() (3.20 KB, patch)
2013-04-01 10:28 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-03-31 15:33:52 UTC 
Be a bit more self-contained and store the .ui files for the account widgets
inside the library using the GResource framework. It should also simplify a bit
the move of the account widgets in a submodule to be shared with g-o-a.
Comment 1 Emanuele Aina 2013-03-31 15:33:55 UTC 
Created attachment 240218 [details] [review]
ui-utils: Add empathy_builder_get_resource()

Add the empathy_builder_get_file() companion to load UI elements from
embedded resources.
Comment 2 Emanuele Aina 2013-03-31 15:34:00 UTC 
Created attachment 240219 [details] [review]
account-widget: Embed .ui files with GResource
Comment 3 Guillaume Desmottes 2013-04-01 06:23:18 UTC 
Review of attachment 240218 [details] [review]:

++
Comment 4 Guillaume Desmottes 2013-04-01 06:24:51 UTC 
Review of attachment 240219 [details] [review]:

::: libempathy-gtk/empathy-irc-network-dialog.c
@@ +30,3 @@
 #include "empathy-irc-network-dialog.h"
 
+#define RESOURCES_PREFIX "/org/gnome/AccountWidgets"

This is defined in 2 C files. Please factor it out to a header file.
Comment 5 Emanuele Aina 2013-04-01 09:06:44 UTC 
Created attachment 240280 [details] [review]
account-widget: Embed .ui files with GResource

Define ACCOUNT_WIDGETS_RESOURCES_PREFIX once in empathy-ui-utils.h
Comment 6 Emanuele Aina 2013-04-01 10:28:31 UTC 
The following fixes have been pushed:
a169a5c account-widget: Embed .ui files with GResource
788d278 ui-utils: Add empathy_builder_get_resource()
Comment 7 Emanuele Aina 2013-04-01 10:28:47 UTC 
Created attachment 240287 [details] [review]
account-widget: Embed .ui files with GResource
Comment 8 Emanuele Aina 2013-04-01 10:28:53 UTC 
Created attachment 240288 [details] [review]
ui-utils: Add empathy_builder_get_resource()

Add the empathy_builder_get_file() companion to load UI elements from
embedded resources.