GNOME Bugzilla – Bug 696974
Embed DTDs with GResource
Last modified: 2013-04-01 10:30:27 UTC
There is no value in storing the DTD used to validate the custom XML formats separately from the code that uses them. Embedding them in the library with the GResource framework will avoid errors due to broken installations and possibly increase performance due to better cache utilization.
Created attachment 240210 [details] [review] utils: Add empathy_xml_validate_from_resource() Validate against dtd stored in a GResource.
Created attachment 240211 [details] [review] Embed DTDs for XML validation as GResources
Created attachment 240215 [details] [review] utils: Drop the file-based empathy_xml_validate() After embedding all the DTDs with GResource the file-based empathy_xml_validate() is no longer needed, replaced by empathy_xml_validate_from_resource().
Review of attachment 240210 [details] [review]: Feel free to merge once the coding style issue is fixed. ::: libempathy/empathy-utils.c @@ +111,2 @@ gboolean +empathy_xml_validate_from_resource (xmlDoc *doc, should be "xmlDoc *doc" according to our coding style.
Review of attachment 240211 [details] [review]: ++ assuming it distchecks.
Review of attachment 240215 [details] [review]: ++
The following fixes have been pushed: f9ba3c0 utils: Drop the file-based empathy_xml_validate() 3992967 Embed DTDs for XML validation as GResources 4299f29 utils: Add empathy_xml_validate_from_resource()
Created attachment 240289 [details] [review] utils: Drop the file-based empathy_xml_validate() After embedding all the DTDs with GResource the file-based empathy_xml_validate() is no longer needed, replaced by empathy_xml_validate_from_resource().
Created attachment 240290 [details] [review] Embed DTDs for XML validation as GResources
Created attachment 240291 [details] [review] utils: Add empathy_xml_validate_from_resource() Validate against dtd stored in a GResource.