GNOME Bugzilla – Bug 696950
Reorganize internal headers inclusion
Last modified: 2013-04-01 10:32:41 UTC
Make internal headers usage more obvious by always using double quotes and a flat namespace, to minimize the churn when changing how the source code is laid out in the repository.
Created attachment 240190 [details] [review] Use double quotes for all internal headers This makes a bit more obvious which headers come from public libraries and which ones come from uninstalled utility libraries.
Created attachment 240191 [details] [review] Avoid include path overspecifications If we're under the libempathy directory there's no need to prefix include file paths with it, and the same is true for libempathy-gtk.
Created attachment 240192 [details] [review] Use a flat namespace for internal includes Directly add the libempathy, libempathy-gtk and extensions directories to the include search path. This decouples header inclusions from their location and helps when reorganizing the source files layout.
Review of attachment 240190 [details] [review]: Please double check with smcv. IIRC he explained ages ago why this was not the proper way to do but I don't remember the rational. Actually it may have been about something completely different.
Review of attachment 240191 [details] [review]: ++
Review of attachment 240192 [details] [review]: Agreed, it's a bit a while we want to reconsider the libempathy(-gtk) separation. Feel free to merge the 3 patches and ignore my first comment.
The following fixes have been pushed: 15460fa Use a flat namespace for internal includes 5c440c4 Avoid include path overspecifications 2ea4af7 Use double quotes for all internal headers
Created attachment 240292 [details] [review] Use a flat namespace for internal includes Directly add the libempathy, libempathy-gtk and extensions directories to the include search path. This decouples header inclusions from their location and helps when reorganizing the source files layout.
Created attachment 240293 [details] [review] Avoid include path overspecifications If we're under the libempathy directory there's no need to prefix include file paths with it, and the same is true for libempathy-gtk.
Created attachment 240294 [details] [review] Use double quotes for all internal headers This makes a bit more obvious which headers come from public libraries and which ones come from uninstalled utility libraries.