GNOME Bugzilla – Bug 696949
The 'Frequent' tab of an application view shows unwanted apps.
Last modified: 2013-04-22 17:20:21 UTC
By unwanted apps, I mean the apps that are hidden by the 'alacarte' app. For example, I have 'Gnome Extension Options' app in the 'Frequent' tab and I don't know how to get rid of it. The 'Frequent' tab should respect the desktop menu specification.
Created attachment 240225 [details] [review] AppDisplay/FrequentView: filter out hidden applications Filter out all applications which have the NoDisplay, Hidden or Not/OnlyShowIn bits, as those are not meant to be launched directly. This also allows the user to filter apps from the frequent view using alacarte.
Review of attachment 240225 [details] [review]: This is wrong if an application is in a category that is NoDisplay or Hidden, or that category is in such a category, etc. You need to use libgmenu's is_nodisplay_recurse() here.
No, categories don't matter here. If I hide an entire category, I'm not hiding the apps inside it from the whole system. I can search them, and I get them in Frequent. Frequent this way operates like a new automatic category.
You can't search for apps that have a hidden category parent, actually. We don't traverse hidden categories when we build visible_id_to_app, which is what the app search system searches. If I hide the Wine category, I wouldn't want it to show up in Frequent, nor in search, nor in my menus. That said, GNOME is constantly moving away from the classic interpretation of the menu spec, so perhaps we should just ignore the NoDisplay state of categories for the ease of implementation.
Can confirm this issue with 3.8.1.
Review of attachment 240225 [details] [review]: Given the recent status of wanting to ignore NoDisplay for categories, let's go with this.
Attachment 240225 [details] pushed as 58872d1 - AppDisplay/FrequentView: filter out hidden applications