GNOME Bugzilla – Bug 696931
Stop randomly fullscreen the window against the user's wish
Last modified: 2013-09-03 19:13:43 UTC
This is just annoying, related IRC discussion: <drago01> cosimoc: is it intentional that documents keeps switching to fullscreen without me asking for it? <drago01> cosimoc: this is really annoying <cosimoc> only when maximized <drago01> why? <drago01> there is a fullscreen option <drago01> if someone wants it <drago01> there is no reason to just do it without the user asking for it <drago01> and even if I unfullscren it <drago01> next time I open a document it does it again <drago01> we shouldn't "fight" the user ... <cosimoc> drago01, the rationale is to avoid any other distractions while reading fullscreen <cosimoc> drago01, ideally we would reveal the shell panel too pushing upwards <cosimoc> *reading maximized sorry <drago01> cosimoc: well by that logic every app should be fullscreen <drago01> cosimoc: that's a rather weak argument <cosimoc> drago01, I am not following your logic <drago01> cosimoc: the app offers 3 views <cosimoc> drago01, it definitely makes sense IMO for e.g. Videos <drago01> cosimoc: unmaximized, maximized and fullscreen <cosimoc> if you have an overview of videos and pick one, you want fullscreen most of the times <drago01> cosimoc: I chose the second ... why doesn't it respect that? <cosimoc> drago01, saying maximized vs. fullscreen in that specific case is an "user choice" is a bit of a stretch IMO * elima (~e-lima@75.98.27.77.dynamic.mundo-r.com) hat #gnome-shell betreten <drago01> cosimoc: why? we do offer the choice and then ignore it anyway <cosimoc> there's not much difference between the two <drago01> cosimoc: there is <cosimoc> and notifications and the panel can be in the way if you want to focus on reading <drago01> that's what the fullscreen option is for <cosimoc> drago01, yeah but that's something you have to do manually <drago01> cosimoc: if I intend to read a long document (say I book) I might want to do that <drago01> cosimoc: but in most cases I simply want to read a small part of the document or look something up <cosimoc> drago01, and why having it fullscreen bothers you? <drago01> cosimoc: and I don'T see why I have to fight the app every time I do that <seif> hi guys <seif> hi cosimoc <seif> cosimoc: how do i do enumerations in gjs <cosimoc> drago01, in any case you want to talk to mccann, he introduced that behavior <drago01> cosimoc: because fullscreen is kind of disconnected from the rest <cosimoc> drago01, it's similar to how it works on e.g. acrobat on ios btw <cosimoc> even though the things you can do with the panel are completely different in that case <cosimoc> seif, something like const MyEnum = { FOO: 1, BAR: 2 }; * bjsnider hat die Verbindung getrennt (Ping timeout: 600 seconds) <seif> cosimoc: thx <drago01> cosimoc: mamized means 1) do see the clock 2) see chats 3) can access the overview easily * mclasen hat die Verbindung getrennt (Ping timeout: 600 seconds) <drago01> cosimoc: if I decide to not care about any of that I can still fullscreen it <cosimoc> drago01, feel free to file a bug and put ui-review on it, or CC mccann * bjsnider (~brandon@216-167-240-136.eastlink.ca) hat #gnome-shell betreten <cosimoc> I am not particularly attached to that behavior, I think it can be useful though * cosimoc has to go now * drago01 files a bug
I am quite fond of the auto-fullscreening behavior for apps that really focus on the content. If you run maximized and select a video or document, it makes sense to me to hide the chrome and put the document itself into focus. For apps that are focused around modifying content, this may not be the best behavior, but I think it's very appropriate for "viewers". What I'm not certain about is the explicit fullscreening, especially in the app menu. Also related to this is the behavior of the overlay toolbars when using mouse input. I think it would be better to show on movement rather than explicit click.
(In reply to comment #1) > I am quite fond of the auto-fullscreening behavior for apps that really focus > on the content. If you run maximized and select a video or document, it makes > sense to me to hide the chrome and put the document itself into focus. I'd prefer if it wasn't such a hack (see 695352) but that's the behaviour that I will be implementing in Videos.
(In reply to comment #1) > I am quite fond of the auto-fullscreening behavior for apps that really focus > on the content. We already have very minimal chrome (no taskbar, doc etc) ... I don't think that a black bar distracts that much from the content. If you run maximized and select a video or document, it makes > sense to me to hide the chrome and put the document itself into focus. > > For apps that are focused around modifying content, this may not be the best > behavior, but I think it's very appropriate for "viewers". A viewer does not imply that you want to focus on that content alone, for instance you might use the viewer to read documentation and chose to maximize to avoid useless scrolling without locking you into the app (e.g no hot corner etc).
*** Bug 701255 has been marked as a duplicate of this bug. ***
> For apps that are focused around modifying content, this may not be the best > behavior, but I think it's very appropriate for "viewers". > I get your point, but, then, you should also use fullscreen by default for Epiphany... Anyway, if fullscreen mode is automatically selected when an item is activated, you should really remove the explicit "fullscreen" mode, and you should make it easier to understand how to get out of fullscreen mode.
Jimmac, Jon and I discussed this briefly at GUADEC and we did consider reverting this behaviour. Not sure if we reached a firm consensus, though.
From #gnome-design: 17:22 <rishi> jimmac: Do you remember what the outcome was from our discussion at GUADEC regarding bug 696931 ? 17:44 <jimmac> rishi: yea we should be fullscreening only explicitly 17:45 <jimmac> rishi: and I'd love to have fullscreen windows treated as if on separate workspace so that no foreign windows can interfere and we don't have to hide fs windows like we do in 310
Created attachment 254013 [details] [review] windowMode: Don't fullscreen the window against the user's wish Stop doing that. When the user explicitly asked for maximize and not fullscreen respect that decision. If the user wants to fullscreen it is one click / button away.
Review of attachment 254013 [details] [review]: Looks good, with the following nitpick. ::: src/windowMode.js @@ -90,3 @@ - if (this._mode != WindowMode.PREVIEW - && this._mode != WindowMode.EDIT) - return; I don't think this check should be removed.
Pushed with suggested change. Attachment 254013 [details] pushed as d6f4a48 - windowMode: Don't fullscreen the window against the user's wish