After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696921 - terminal crashes when opening the profile editor
terminal crashes when opening the profile editor
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Profiles
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
3.8.1
: 696953 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-30 19:38 UTC by Emilio Pozuelo Monfort
Modified: 2013-03-31 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Emilio Pozuelo Monfort 2013-03-30 19:38:41 UTC
Running gnome-terminal 3.8.0, vte 0.34.2, gtk+ 3.8.0 and glib 2.36.0.

gnome-terminal crashes reproducibly when opening Profile Preferences.

It spits 4 warnings and then crashes.

(gnome-terminal-server:8302): Gtk-WARNING **: Unknown property: GtkHScale.update-policy

(gnome-terminal-server:8302): Gtk-CRITICAL **: gtk_label_set_text: assertion `GTK_IS_LABEL (label)' failed

(gnome-terminal-server:8302): GLib-GIO-CRITICAL **: g_settings_bind_with_mapping: assertion `G_IS_OBJECT (object)' failed

(gnome-terminal-server:8302): GLib-GIO-CRITICAL **: g_settings_bind_with_mapping: assertion `G_IS_OBJECT (object)' failed

The crash is in a different place than the four warnings though, in src/profile-editor.c, around the end of the file:

  g_settings_bind_writable (profile,
                            TERMINAL_PROFILE_PALETTE_KEY,
                            gtk_builder_get_object (builder, "palette-box"),
                            "sensitive",
                            FALSE);

The problem is that src/profile-preferences.ui doesn't contain "palette-box". Commenting out that code stops the crash from happening.

As for the two g_settings_bind_with_mapping(), they are also in src/profile-editor.c because missing objects from profile-preferences.ui.

  g_settings_bind (profile, TERMINAL_PROFILE_BOLD_COLOR_SAME_AS_FG_KEY,
                   gtk_builder_get_object (builder,
                                           "bold-colorpicker-box"),

  g_settings_bind_with_mapping (profile,
                                TERMINAL_PROFILE_SCROLLBAR_POLICY_KEY,
                                gtk_builder_get_object (builder,
                                                        "scrollbar-policy-combobox"),
                                "active",
                                G_SETTINGS_BIND_GET | G_SETTINGS_BIND_SET,
                                (GSettingsBindGetMapping) string_to_enum,
                                (GSettingsBindSetMapping) enum_to_string,
                                gtk_policy_type_get_type, NULL);

These two don't make gnome-terminal crash.
Comment 1 Christian Persch 2013-03-31 08:49:53 UTC
$ git grep palette-box
src/profile-editor.c:                            gtk_builder_get_object (builder, "palette-box"),
src/profile-preferences.ui:                  <object class="GtkVBox" id="palette-box">
Comment 2 Antoine Jacoutot 2013-03-31 10:09:36 UTC
*** Bug 696953 has been marked as a duplicate of this bug. ***
Comment 3 Antoine Jacoutot 2013-03-31 10:20:52 UTC
Getting the latest src/profile-preferences.ui from git fixes it. But it's not part of the 3.8.0 tarball.
Comment 4 Christian Persch 2013-03-31 13:53:49 UTC
Looks like a automake bug? It seems the .ui files were taken from builddir where they existed because of a build from 3-6 branch I had done, instead of from srcdir...
Comment 5 Christian Persch 2013-03-31 14:07:42 UTC
Should be fixed in version 3.8.0.1.
Comment 6 Christian Persch 2013-03-31 14:14:55 UTC
(Ran into a problem uploading 3.8.0.1: bug 696969.)