GNOME Bugzilla – Bug 696903
MIME database regeneration at 'make install' time
Last modified: 2013-03-30 20:35:11 UTC
Meld 1.7.1 started running update-mime-database and update-desktop-database at 'make install' time. This is problematic with binary downstream packages, because distros don't include cache files in binary packages, but instead regenerate them after package installation at the end user's machine. Because of that, they don't want the icon cache regeneration during build time. So we have two cases: - Binary redistributors, who do not want to run these commands at build time - People who install from source, there the cache updates are very useful One way to distinguish between these two cases it to check DESTDIR. If it's set, we aren't installing in the final location and thus shouldn't update the cache files.
Created attachment 240166 [details] [review] build: Only update the MIME cache when DESTDIR isn't set This adds a check to run update-mime-database / update-desktop-database only when DESTDIR isn't set. We don't want to include the generated cache files in downstream packages. These should be regenerated on the user's machine, not on the build host.
Thanks for the patch. I've pushed it to HEAD.