After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696900 - ORBit2 fails to build with new glib
ORBit2 fails to build with new glib
Status: RESOLVED FIXED
Product: ORBit2
Classification: Deprecated
Component: general
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: ORBit maintainers
ORBit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-30 11:49 UTC by Vladimír Čunát
Modified: 2017-07-30 19:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix build with glib 2.36 (898 bytes, patch)
2013-05-03 08:16 UTC, Andreas Müller
none Details | Review

Description Vladimír Čunát 2013-03-30 11:49:31 UTC
I believe it's due to usage of deprecated stuff that now got removed.

...
/bin/sh ../../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../linc2/include -I../../linc2/include -pthread -I/nix/store/0rxbyx9hyk6k6k1bsry9fyy1597lshdz-glib-2.36.0/include/glib-2.0 -I/nix/store/0rxbyx9hyk6k6k1bsry9fyy1597lshdz-glib-2.36.0/lib/glib-2.0/include   -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -DG_DISABLE_DEPRECATED -D_GNU_SOURCE    -g -O2 -Werror-implicit-function-declaration  -c -o linc.lo linc.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../linc2/include -I../../linc2/include -pthread -I/nix/store/0rxbyx9hyk6k6k1bsry9fyy1597lshdz-glib-2.36.0/include/glib-2.0 -I/nix/store/0rxbyx9hyk6k6k1bsry9fyy1597lshdz-glib-2.36.0/lib/glib-2.0/include -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -DG_DISABLE_DEPRECATED -D_GNU_SOURCE -g -O2 -Werror-implicit-function-declaration -c linc.c  -fPIC -DPIC -o .libs/linc.o
linc.c: In function 'link_init':
linc.c:199:2: error: implicit declaration of function 'g_thread_supported' [-Werror=implicit-function-declaration]
linc.c:200:3: error: implicit declaration of function 'g_thread_init' [-Werror=implicit-function-declaration]
linc.c:204:2: warning: 'g_type_init' is deprecated (declared at /nix/store/0rxbyx9hyk6k6k1bsry9fyy1597lshdz-glib-2.36.0/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
linc.c:262:3: error: implicit declaration of function 'g_cond_new' [-Werror=implicit-function-declaration]
linc.c:262:18: warning: assignment makes pointer from integer without a cast [enabled by default]
linc.c:263:23: warning: assignment makes pointer from integer without a cast [enabled by default]
linc.c: In function 'link_mutex_new':
linc.c:324:3: error: implicit declaration of function 'g_mutex_new' [-Werror=implicit-function-declaration]
linc.c:324:3: warning: return makes pointer from integer without a cast [enabled by default]
linc.c: In function 'link_exec_set_io_thread':
linc.c:463:3: error: implicit declaration of function 'g_thread_create_full' [-Werror=implicit-function-declaration]
linc.c:464:4: error: 'G_THREAD_PRIORITY_NORMAL' undeclared (first use in this function)
linc.c:464:4: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
make[3]: *** [linc.lo] Error 1
make[3]: Leaving directory `/tmp/nix-build-ORBit2-2.14.19.drv-10/ORBit2-2.14.19/linc2/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/nix-build-ORBit2-2.14.19.drv-10/ORBit2-2.14.19/linc2'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/nix-build-ORBit2-2.14.19.drv-10/ORBit2-2.14.19'
make: *** [all] Error 2
builder for `/nix/store/3rybi0m2ag1y1ngq0v8xi01dplyvibg0-ORBit2-2.14.19.drv' failed with exit code 2
error: build of `/nix/store/3rybi0m2ag1y1ngq0v8xi01dplyvibg0-ORBit2-2.14.19.drv' failed
Comment 1 Ryan Schmidt 2013-03-31 21:59:59 UTC
We are no longer able to build ORBit2 2.14.19 in MacPorts because of this issue. https://trac.macports.org/ticket/38610
Comment 2 Vladimír Čunát 2013-04-08 13:59:23 UTC
We temporarily worked around the build issue by
sed 's/-DG_DISABLE_DEPRECATED//' -i linc2/src/Makefile

Thanks to https://github.com/MarcWeber
Comment 3 Andreas Müller 2013-05-03 08:16:08 UTC
Created attachment 243149 [details] [review]
fix build with glib 2.36

Just in case somebody creates a new release..
Comment 4 Kjartan Maraas 2013-05-14 11:33:47 UTC
I've commited a slightly different fix for this and some other build related problems and noise from autotools. Please try git master and see how this works for you?
Comment 5 Kjartan Maraas 2017-07-30 19:00:48 UTC
Closing as fixed.