GNOME Bugzilla – Bug 696891
Hitting Home/End from any page should add a page to the history
Last modified: 2018-05-22 15:03:19 UTC
I often hit "Home" and then don't know the way to return last page I was viewing. Please make a feature to solve this problem. Any suggestions.
Maybe Home/End should add history entries.
(In reply to comment #1) > Maybe Home/End should add history entries. AFAIU, they do (whenever the page changes).
Now I can see the issue. If you are reading the document page by page, there is no history if you press Home/End.
Hi i am interested in this bug. Is this easy bug for new person to work on?
Hi, I am interested in this bug. Please guide me in solving this bug.
(In reply to comment #2) > AFAIU, they do (whenever the page changes). They add history entries for the new page, in this case the home/end pages. The issue is related to https://bugzilla.gnome.org/show_bug.cgi?id=710681, since in both cases the 'missing page' is the one from which we jumped. I think adding 'old_page' to the history at every 'page-change' signal in addition to the 'new_page' would fix it.
Created attachment 269546 [details] [review] Removes the condition that adds history only if new_page>old_page I added a patch.This seems to solve the problem.would like it if anyone could review it.
I think by doing this in the page-changed handler, you'll add a history entry for every page change, e.g. if you just scroll with the mouse from page N to page N+1 ? That's not desirable, IMO.
Created attachment 269848 [details] [review] Solves the issue where per page scrolling adds the pages. I think this should solve the issue.It works for both Home/End buttons
Created attachment 269877 [details] [review] Takes Christian Perch's view into account This one fixes the coding style issues in the previous patch.
Created attachment 269878 [details] [review] Fixes the issue mentioned by Christian Perch Also fixes the coding style issues in the previous patches
Created attachment 269887 [details] [review] Fixes the issue mentioned by Christian Perch Also fixes the coding style issues in the previous patches
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/338.