GNOME Bugzilla – Bug 696835
Use correctly sized fedora/ubuntu logos
Last modified: 2016-03-31 13:22:07 UTC
The ubuntu and fedora logos are a bit bigger than the CD icon in the media list, Jimmac was kind enough to make properly sized logos, they are at http://jimmac.fedorapeople.org/gnome3/boxes/logos/ Would be great to use these instead of the ones we are currectly using (for the ubuntu logo, the gnome-boxes-logos-db.xml will need to be updated as well). Zeeshan, can you upload these logos to http://people.gnome.org/~zeeshanak/logos ? Thanks!
Created attachment 240506 [details] [review] Use correctly sized logos
Review of attachment 240506 [details] [review]: ACK, wondering if the README.logos file needs changes or not (I'm not sure after looking at it)
Attachment 240506 [details] pushed as e86caf6 - Use correctly sized logos
Oh, missed a question I wanted to ask, I guess you updated the fedora logo in place, will the new one be downloaded as expected on systems that have already cached it?
(In reply to comment #4) > Oh, missed a question I wanted to ask, I guess you updated the fedora logo in > place, will the new one be downloaded as expected on systems that have already > cached it? Actually no. I'll fix this..
Created attachment 240539 [details] [review] logo: Ensure new Fedora logo gets used I had replaced fedora logo in-place and since we only look for existance of file by the same name in cache, downloader will not download/refresh the logo if the previous version has been downloaded once. Now i gave the new logo file a different name and updating it also in our logo db.
Review of attachment 240539 [details] [review]: s/existance/existence/ s/i gave/I gave/ s/updating/I updated/
Attachment 240539 [details] pushed as 521c2b4 - logo: Ensure new Fedora logo gets used