After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696749 - win32 : failed to compile because of careless mistake in the code
win32 : failed to compile because of careless mistake in the code
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.36.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-03-28 05:11 UTC by LE GARREC Vincent
Modified: 2015-05-25 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for right compilation (372 bytes, patch)
2013-03-28 05:12 UTC, LE GARREC Vincent 		none Details | Review

Description LE GARREC Vincent 2013-03-28 05:11:38 UTC 
The patch says all.

g_message (win32_message); => g_message ("(%s)", win32_message);
Comment 1 LE GARREC Vincent 2013-03-28 05:12:54 UTC 
Created attachment 240010 [details] [review]
Patch for right compilation
Comment 2 Nirbheek Chauhan 2015-05-25 09:33:43 UTC 
Patch is trivially correct; can we get this in please?
Comment 3 Emmanuele Bassi (:ebassi) 2015-05-25 13:11:24 UTC 
Thanks for the patch, and sorry for taking this long.

For future reference, please:

 * explain what kind of build failure and/or warning you get, and include the build flags used
 * use a Git-formatted patch (e.g. via `git format-patch` or using `git bz`), so that we can easily apply it, as well as credit the author properly
 * try not to insult people working on GLib in bug reports — "because of careless mistake" is not a nice phrasing

This will make your patch submissions likely to be looked after in a timely manner.

Thanks again for the patch.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 4 Nirbheek Chauhan 2015-05-25 13:13:38 UTC 
Thanks for looking at this, Emmanuele!