After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696709 - Use configure.ac's VERSION instead of BUILD_VERSION
Use configure.ac's VERSION instead of BUILD_VERSION
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-27 15:51 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use configure.ac's VERSION instead of BUILD_VERSION (2.82 KB, patch)
2013-03-27 15:51 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2013-03-27 15:51:48 UTC 
Boxes 3.8.0 reports 3.7.91 as its version even though .tarball-version
has the correct 3.8.0 version. However .version contains 3.7.91,
and this is what is currently used to generate BUILD_VERSION.
Since config.h already provides us with a VERSION #define, it's
better to use this one rather than guessing a version on our
own.
Comment 1 Christophe Fergeau 2013-03-27 15:51:50 UTC 
Created attachment 239964 [details] [review]
Use configure.ac's VERSION instead of BUILD_VERSION
Comment 2 Marc-Andre Lureau 2013-03-27 16:00:57 UTC 
Review of attachment 239964 [details] [review]:

agree (I think that is a relic of how vala.git is doing, but we don't need that)
Comment 3 Christophe Fergeau 2013-03-27 17:20:45 UTC 
Attachment 239964 [details] pushed as 34e5928 - Use configure.ac's VERSION instead of BUILD_VERSION