After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696659 - perf test regressed: it no longer sees all 500 contacts
perf test regressed: it no longer sees all 500 contacts
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-26 19:15 UTC by Simon McVittie
Modified: 2013-03-27 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Edsf.PersonaStore: defer contacts-complete like contacts-added (1.95 KB, patch)
2013-03-26 19:15 UTC, Simon McVittie 		accepted-commit_now Details | Review

Description Simon McVittie 2013-03-26 19:15:07 UTC 
Created attachment 239891 [details] [review]
Edsf.PersonaStore: defer contacts-complete like contacts-added

Otherwise, we signal quiescence while not actually quiescent: our
initial batch of contacts could still be coming in.

---

This affects the "perf" test I added recently, which typically only sees 0-48 contacts on my laptop. With this change, it gets all 500 again.
Comment 1 Philip Withnall 2013-03-26 19:53:51 UTC 
Review of attachment 239891 [details] [review]:

Yay for unit tests!
Comment 2 Simon McVittie 2013-03-27 12:36:50 UTC 
62fe0c462, fixed in git for 0.9.2.