GNOME Bugzilla – Bug 696653
resizing columns in History window hangs user interface
Last modified: 2013-11-26 12:04:24 UTC
I'm running Epiphany 3.8.0 on Ubuntu 13.4 (Raring). I have libgtk 3.7.12. When I attempt to resize the columns in the History window by moving the slider between the Title and Address columns, Epiphany hangs. In fact, the entire desktop hangs: no matter where I move the mouse cursor, it looks like the resize column cursor and when I click anywhere nothing happens. I have to log into another virtual terminal and kill my session to continue working. I wonder whether this bug is specific to Ubuntu.
If the whole desktop hangs then it's probably a WM issue. Could you try with a different one or the gnome shell for example?
I can repro this here, seems like a GTK+ bug too. The desktop is not hanging, but you cannot do anything because the cursor is stuck.
Since Xan sees this too (and I'm pretty sure he runs GNOME Shell) I think we can remove the NEEDINFO status. Xan, can you set the status to NEW or ASSIGNED?
Sure, it is a real bug.
*** Bug 704175 has been marked as a duplicate of this bug. ***
This is still happening in git master with GTK 3.10.2.
This is a regression from commit 12c23 where middle-click support was added. I'll submit a patch.
Created attachment 261330 [details] [review] Call parent class on button release
Created attachment 261331 [details] [review] Alternatively, we could just go back to using a signal here
Ignore the alternative patch, won't work. First patch will work. :)
Review of attachment 261330 [details] [review]: Good catch. Shouldn't the patch do something akin to what is done in ephy_history_view_butto_press() (that is, only call the parent class handler when the event is not happening on the bin window)?
Created attachment 262803 [details] [review] Call parent class on button release
Review of attachment 262803 [details] [review]: ::: lib/widgets/ephy-history-view.c @@ +108,3 @@ + if (event->window != gtk_tree_view_get_bin_window (GTK_TREE_VIEW (treeview))) + GTK_WIDGET_CLASS (ephy_history_view_parent_class)->button_release_event (treeview, event); This is missing the return. We only want to handle the middle click when the event window is the bin window. Check the button_press() handler. @@ -119,3 @@ gtk_tree_path_free (path); } - No need for this.
Created attachment 262817 [details] [review] Call parent class on button release Sorry about the silly mistakes. Third time's the charm?
Review of attachment 262817 [details] [review]: Patch is missing a commit message, I suppose you'll add one (and a reference to this bug report). Also commit to the stable branch. Thank you!
So just add a commit message, reference this bug, and toss the patch up here? Also, which branch is stable? It isn't clear to me.
Do you have commit rights? If so, please commit it to both master and gnome-3-10 branches. If you don't have a git account I can commit it for you. No need to upload it here.
I don't have commit rights, so if you could go ahead and commit it, that will work. :)
I pushed to master, gnome-3-10, and gnome-3-8 in case anyone is still shipping from that branch.
Thanks, Daniel and Claudio! Actually I'm still running 3.8 and it's very helpful to have this fix on that branch too.