After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696652 - GTask won't free its error member variable on finalize
GTask won't free its error member variable on finalize
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 696644 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-26 15:51 UTC by Xan Lopez
Modified: 2013-03-26 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtask: free error on finalize if it's set (720 bytes, patch)
2013-03-26 18:20 UTC, Xan Lopez
committed Details | Review

Description Xan Lopez 2013-03-26 15:51:33 UTC
==1498== 120 (48 direct, 72 indirect) bytes in 3 blocks are definitely lost in loss record 7,370 of 9,001
==1498==    at 0x4A0887C: malloc (vg_replace_malloc.c:270)
==1498==    by 0x7DBB78A: g_malloc (gmem.c:159)
==1498==    by 0x7DD4031: g_slice_alloc (gslice.c:1003)
==1498==    by 0x7D9C3C7: g_error_new_literal (gerror.c:456)
==1498==    by 0x7D9C69F: g_set_error_literal (gerror.c:595)
==1498==    by 0x7B9C37E: g_cancellable_set_error_if_cancelled (gcancellable.c:315)
==1498==    by 0x7AFAA6C: io_run_until (soup-message-io.c:841)
==1498==    by 0x7AFB047: soup_message_io_run_until_read (soup-message-io.c:963)
==1498==    by 0x7B0D123: try_run_until_read (soup-session.c:3763)
==1498==    by 0x7B0D0E1: read_ready_cb (soup-session.c:3753)
==1498==    by 0x7AFA3B6: message_source_dispatch (soup-message-io.c:720)
==1498==    by 0x7DB3414: g_main_dispatch (gmain.c:3054)
==1498==    by 0x7DB4179: g_main_context_dispatch (gmain.c:3630)
==1498==    by 0x7DB4369: g_main_context_iterate (gmain.c:3701)
==1498==    by 0x7DB4799: g_main_loop_run (gmain.c:3895)
==1498==    by 0x56A1EA3: WebProcessMainGtk (in /home/xan/gnome/lib64/libwebkit2gtk-3.0.so.22.2.0)
==1498==    by 0x3C65021A04: (below main) (libc-start.c:225)
Comment 1 Xan Lopez 2013-03-26 18:16:26 UTC
*** Bug 696644 has been marked as a duplicate of this bug. ***
Comment 2 Xan Lopez 2013-03-26 18:16:48 UTC
Leak is actually in GTask itself, reassigning.
Comment 3 Xan Lopez 2013-03-26 18:20:41 UTC
Created attachment 239888 [details] [review]
gtask: free error on finalize if it's set
Comment 4 Xan Lopez 2013-03-26 18:21:23 UTC
ACKed by danw on IRC, pushed to master.