After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696570 - style updates
style updates
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal enhancement
: 1.20
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-25 17:15 UTC by Andreas Nilsson
Modified: 2013-07-24 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (6.26 KB, image/png)
2013-03-25 17:15 UTC, Andreas Nilsson
  Details
mockup (169.67 KB, image/png)
2013-07-16 17:35 UTC, Andreas Nilsson
  Details
alternate mockup (167.32 KB, image/png)
2013-07-16 17:35 UTC, Andreas Nilsson
  Details
Depink the navigation bar (1.55 KB, patch)
2013-07-16 19:19 UTC, William Jon McCann
none Details | Review
Use symbolic icons for the navigation links (11.17 KB, patch)
2013-07-16 19:19 UTC, William Jon McCann
none Details | Review
Make the navigation bar layout more stable (10.89 KB, patch)
2013-07-16 19:20 UTC, William Jon McCann
none Details | Review
how it looks (171.53 KB, image/png)
2013-07-16 19:20 UTC, William Jon McCann
  Details
mockup (160.46 KB, image/png)
2013-07-16 21:36 UTC, William Jon McCann
  Details
Improve the design of the navigation bar (29.83 KB, patch)
2013-07-16 22:26 UTC, William Jon McCann
none Details | Review
How it looks with the patch applied (160.46 KB, image/png)
2013-07-16 22:27 UTC, William Jon McCann
  Details
Make top actually go to the top of the section (1.83 KB, patch)
2013-07-16 22:56 UTC, William Jon McCann
none Details | Review
Don't use italics for parameters (672 bytes, patch)
2013-07-16 23:16 UTC, William Jon McCann
none Details | Review
Add more whitespace to some blocks (967 bytes, patch)
2013-07-17 17:44 UTC, William Jon McCann
none Details | Review
Add a little space in the table of contents lists (764 bytes, patch)
2013-07-18 02:18 UTC, William Jon McCann
none Details | Review
Improve the design of the navigation bar (29.83 KB, patch)
2013-07-18 18:42 UTC, William Jon McCann
none Details | Review
Depink the navigation bar (1.55 KB, patch)
2013-07-18 19:13 UTC, William Jon McCann
committed Details | Review
Use symbolic icons for the navigation links (11.17 KB, patch)
2013-07-18 19:13 UTC, William Jon McCann
committed Details | Review
Improve the design of the navigation bar (29.83 KB, patch)
2013-07-18 19:13 UTC, William Jon McCann
committed Details | Review
Make top actually go to the top of the section (1.83 KB, patch)
2013-07-18 19:13 UTC, William Jon McCann
committed Details | Review
Don't use italics for parameters (672 bytes, patch)
2013-07-18 19:14 UTC, William Jon McCann
committed Details | Review
Add more whitespace to some blocks (967 bytes, patch)
2013-07-18 19:14 UTC, William Jon McCann
none Details | Review
Add a little space in the table of contents lists (764 bytes, patch)
2013-07-18 19:14 UTC, William Jon McCann
none Details | Review
screenshot table of contents (97.75 KB, image/png)
2013-07-23 14:16 UTC, William Jon McCann
  Details
screenshot ref page (179.99 KB, image/png)
2013-07-23 14:17 UTC, William Jon McCann
  Details
Add more whitespace to some blocks (1.09 KB, patch)
2013-07-23 16:20 UTC, William Jon McCann
none Details | Review
Add a little space in the table of contents lists (766 bytes, patch)
2013-07-23 16:20 UTC, William Jon McCann
none Details | Review
Decrease the title font size a bit (577 bytes, patch)
2013-07-23 16:20 UTC, William Jon McCann
none Details | Review
reduce padding around blocks a bit more (1.09 KB, patch)
2013-07-24 18:40 UTC, William Jon McCann
none Details | Review
Add a little space in the table of contents lists (766 bytes, patch)
2013-07-24 19:57 UTC, William Jon McCann
committed Details | Review
Decrease the title font size a bit (577 bytes, patch)
2013-07-24 19:57 UTC, William Jon McCann
committed Details | Review
Use cantarell by default (550 bytes, patch)
2013-07-24 19:57 UTC, William Jon McCann
committed Details | Review
Don't hardcode style in the markup (739 bytes, patch)
2013-07-24 19:57 UTC, William Jon McCann
committed Details | Review
Lighten hard rules a bit (683 bytes, patch)
2013-07-24 19:57 UTC, William Jon McCann
committed Details | Review

Description Andreas Nilsson 2013-03-25 17:15:24 UTC
Created attachment 239796 [details]
screenshot

Someone described the color as salmon pink.
Not only does it redness attract way too much attention, but it just looks bad together with the rest of the product I would say.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2013-03-25 18:55:46 UTC
You probably refer to this
/* tango:scarlet red 0/1 */
background: #ffe6e6;

If you remember, once upon a time everything on the gnome desktop was following the tango style and so did gtk-doc.
https://git.gnome.org/browse/gtk-doc/tree/style.css

Before it looked like this:
https://git.gnome.org/browse/gtk-doc/tree/style-classic.css

And in the future it could look different, I take patches :)
Comment 2 Andreas Nilsson 2013-03-27 12:26:59 UTC
Scarlet red is #ef2929, #cc00000 or #a40000. [1]
As I want to use red for warnings, I think I'll try and do something gray or blue instead.

Good to see it's css, will cook up a patch!


1. http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines#Color_Palette
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2013-05-30 16:34:08 UTC
I'd like to make a release soon. Did you had time to tweak the style?
Comment 4 Andreas Nilsson 2013-07-16 17:35:02 UTC
Created attachment 249308 [details]
mockup
Comment 5 Andreas Nilsson 2013-07-16 17:35:22 UTC
Created attachment 249309 [details]
alternate mockup
Comment 6 Andreas Nilsson 2013-07-16 17:40:32 UTC
Jimmac and Paolo preferred the second mockup when I asked on IRC.
Comment 7 William Jon McCann 2013-07-16 19:19:53 UTC
Created attachment 249315 [details] [review]
Depink the navigation bar
Comment 8 William Jon McCann 2013-07-16 19:19:56 UTC
Created attachment 249316 [details] [review]
Use symbolic icons for the navigation links
Comment 9 William Jon McCann 2013-07-16 19:20:00 UTC
Created attachment 249317 [details] [review]
Make the navigation bar layout more stable

Put the title to the left, buttons at the right, and insert placeholder icons
instead of hiding the links when necessary.
Comment 10 William Jon McCann 2013-07-16 19:20:44 UTC
Created attachment 249318 [details]
how it looks
Comment 11 Andreas Nilsson 2013-07-16 20:07:05 UTC
(In reply to comment #10)
> Created an attachment (id=249318) [details]
> how it looks

Looks good!
Comment 12 William Jon McCann 2013-07-16 21:36:53 UTC
Created attachment 249323 [details]
mockup

On second thought. Would rather go for something like this. Working on it.
Comment 13 William Jon McCann 2013-07-16 22:26:13 UTC
Created attachment 249326 [details] [review]
Improve the design of the navigation bar

Put the shortcuts on the left, buttons at the right, and insert placeholder icons
instead of hiding the links when necessary.

Move the book title into the page title.
Comment 14 William Jon McCann 2013-07-16 22:27:15 UTC
Created attachment 249327 [details]
How it looks with the patch applied
Comment 15 William Jon McCann 2013-07-16 22:56:10 UTC
Created attachment 249331 [details] [review]
Make top actually go to the top of the section
Comment 16 William Jon McCann 2013-07-16 23:16:47 UTC
Created attachment 249333 [details] [review]
Don't use italics for parameters

The default appearance of <em> is italics and that is
distracting and harder to read while offering no advantages.
Comment 17 William Jon McCann 2013-07-17 17:44:30 UTC
Created attachment 249426 [details] [review]
Add more whitespace to some blocks

This adds some "air" to make the pages more readable.
Comment 18 William Jon McCann 2013-07-18 02:18:14 UTC
Created attachment 249462 [details] [review]
Add a little space in the table of contents lists
Comment 19 William Jon McCann 2013-07-18 18:42:37 UTC
Created attachment 249555 [details] [review]
Improve the design of the navigation bar

Put the shortcuts on the left, buttons at the right, and insert placeholder icons
instead of hiding the links when necessary.

Move the book title into the page title.
Comment 20 William Jon McCann 2013-07-18 19:13:45 UTC
Created attachment 249559 [details] [review]
Depink the navigation bar
Comment 21 William Jon McCann 2013-07-18 19:13:52 UTC
Created attachment 249560 [details] [review]
Use symbolic icons for the navigation links
Comment 22 William Jon McCann 2013-07-18 19:13:55 UTC
Created attachment 249561 [details] [review]
Improve the design of the navigation bar

Put the shortcuts on the left, buttons at the right, and insert placeholder icons
instead of hiding the links when necessary.

Move the book title into the page title.
Comment 23 William Jon McCann 2013-07-18 19:13:59 UTC
Created attachment 249562 [details] [review]
Make top actually go to the top of the section
Comment 24 William Jon McCann 2013-07-18 19:14:04 UTC
Created attachment 249563 [details] [review]
Don't use italics for parameters

The default appearance of <em> is italics and that is
distracting and harder to read while offering no advantages.
Comment 25 William Jon McCann 2013-07-18 19:14:08 UTC
Created attachment 249564 [details] [review]
Add more whitespace to some blocks

This adds some "air" to make the pages more readable.
Comment 26 William Jon McCann 2013-07-18 19:14:12 UTC
Created attachment 249565 [details] [review]
Add a little space in the table of contents lists
Comment 27 Stefan Sauer (gstreamer, gtkdoc dev) 2013-07-19 20:06:21 UTC
Review of attachment 249426 [details] [review]:

I am not fond of this part. To be honest, me first thought was that there is some text missing.
Comment 28 William Jon McCann 2013-07-22 19:28:47 UTC
And the rest?
Comment 29 William Jon McCann 2013-07-23 14:16:50 UTC
Created attachment 249893 [details]
screenshot table of contents
Comment 30 William Jon McCann 2013-07-23 14:17:40 UTC
Created attachment 249894 [details]
screenshot ref page
Comment 31 William Jon McCann 2013-07-23 16:20:50 UTC
Created attachment 249920 [details] [review]
Add more whitespace to some blocks

This adds some "air" to make the pages more readable.
Comment 32 William Jon McCann 2013-07-23 16:20:53 UTC
Created attachment 249921 [details] [review]
Add a little space in the table of contents lists
Comment 33 William Jon McCann 2013-07-23 16:20:56 UTC
Created attachment 249922 [details] [review]
Decrease the title font size a bit

200% is way too huge
Comment 34 William Jon McCann 2013-07-24 18:40:12 UTC
Created attachment 250060 [details] [review]
reduce padding around blocks a bit more
Comment 35 William Jon McCann 2013-07-24 19:57:14 UTC
Created attachment 250067 [details] [review]
Add a little space in the table of contents lists
Comment 36 William Jon McCann 2013-07-24 19:57:18 UTC
Created attachment 250068 [details] [review]
Decrease the title font size a bit

200% is way too huge
Comment 37 William Jon McCann 2013-07-24 19:57:21 UTC
Created attachment 250069 [details] [review]
Use cantarell by default
Comment 38 William Jon McCann 2013-07-24 19:57:25 UTC
Created attachment 250070 [details] [review]
Don't hardcode style in the markup

Let CSS handle it all.
Comment 39 William Jon McCann 2013-07-24 19:57:29 UTC
Created attachment 250071 [details] [review]
Lighten hard rules a bit
Comment 40 Stefan Sauer (gstreamer, gtkdoc dev) 2013-07-24 20:29:12 UTC
Attachment 249559 [details] pushed as deb01a8 - Depink the navigation bar
Attachment 249560 [details] pushed as 939576c - Use symbolic icons for the navigation links
Attachment 249561 [details] pushed as 0fab530 - Improve the design of the navigation bar
Attachment 249562 [details] pushed as 7c693e1 - Make top actually go to the top of the section
Attachment 249563 [details] pushed as 108e75e - Don't use italics for parameters
Attachment 250067 [details] pushed as 7846515 - Add a little space in the table of contents lists
Attachment 250068 [details] pushed as 127ae4d - Decrease the title font size a bit
Attachment 250069 [details] pushed as 992260d - Use cantarell by default
Attachment 250070 [details] pushed as 1f7be76 - Don't hardcode style in the markup
Attachment 250071 [details] pushed as 1846fc7 - Lighten hard rules a bit