GNOME Bugzilla – Bug 696544
goa-mc-plugin: Fix deprecation warnings
Last modified: 2013-03-27 14:45:22 UTC
The attached patch fixes the following deprecation warnings and unbreaks `make distcheck' as it uses -Werror. make[2]: Entering directory `/home/em/c/co/tizen-pc/empathy/goa-mc-plugin' CC mcp-account-manager-goa.lo mcp-account-manager-goa.c: In function 'account_storage_iface_init': mcp-account-manager-goa.c:607:3: warning: 'mcp_account_storage_iface_set_name' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:158): Use 'iface->name = name' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:608:3: warning: 'mcp_account_storage_iface_set_desc' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:162): Use 'iface->desc = desc' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:609:3: warning: 'mcp_account_storage_iface_set_priority' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:154): Use 'iface->priority = prio' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:610:3: warning: 'mcp_account_storage_iface_set_provider' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:166): Use 'iface->provider = provider' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:614:3: warning: 'mcp_account_storage_iface_implement_get' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:170): Use 'iface->get = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:615:3: warning: 'mcp_account_storage_iface_implement_list' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:183): Use 'iface->list = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:616:3: warning: 'mcp_account_storage_iface_implement_set' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:173): Use 'iface->set = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:617:3: warning: 'mcp_account_storage_iface_implement_delete' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:180): Use 'iface->delete = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:618:3: warning: 'mcp_account_storage_iface_implement_commit' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:186): Use 'iface->commit = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:619:3: warning: 'mcp_account_storage_iface_implement_ready' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:193): Use 'iface->ready = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:620:3: warning: 'mcp_account_storage_iface_implement_get_restrictions' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:204): Use 'iface->get_restrictions = method' instead [-Wdeprecated-declarations] mcp-account-manager-goa.c:621:3: warning: 'mcp_account_storage_iface_implement_get_identifier' is deprecated (declared at /gnome-world-3.8/build/include/mission-control-5.5/mission-control-plugins/account-storage.h:196): Use 'iface->get_identifier = method' instead [-Wdeprecated-declarations] CCLD mcp-account-manager-goa.la
Created attachment 239740 [details] [review] goa-mc-plugin: Fix deprecation warnings
Looks good, but you need to bump the MC dependency probably.
AIUI we don't need any bump as we're doing exactly what the deprecated functions were doing, and the fields were already public. This is the commit which deprecated those functions: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=f976919e This is where the fields were made public (released in mc 5.7.11 and we depend on 5.13.1): http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=34434732
Review of attachment 239740 [details] [review]: All good then.
The following fix has been pushed: 22e67d0 goa-mc-plugin: Fix deprecation warnings
Created attachment 239955 [details] [review] goa-mc-plugin: Fix deprecation warnings