After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696529 - stack-switcher: Show the buttons only if there is a title or an icon
stack-switcher: Show the buttons only if there is a title or an icon
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-25 00:41 UTC by Debarshi Ray
Modified: 2013-03-25 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stack-switcher: Show the buttons only if there is a title or an icon (1.39 KB, patch)
2013-03-25 00:42 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2013-03-25 00:41:36 UTC
The GdStack in Photos has children for the overview, favourites, preview, a spinner, an error message, etc.. Of these only the overview and the favourites should be exposed to the user via the GdStackSwitcher. The others are programmatically shown or hidden as a result of other activities or events.
Comment 1 Debarshi Ray 2013-03-25 00:42:48 UTC
Created attachment 239717 [details] [review]
stack-switcher: Show the buttons only if there is a title or an icon
Comment 2 Cosimo Cecchi 2013-03-25 14:39:02 UTC
Review of attachment 239717 [details] [review]:

This sounds reasonable, thanks.
Comment 3 Debarshi Ray 2013-03-25 15:01:14 UTC
Thanks for the review. Pushed.