After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696491 - Bad links
Bad links
Status: RESOLVED FIXED
Product: gnome-user-docs
Classification: Core
Component: gnome-help
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on:
Blocks:
 
 
Reported: 2013-03-24 13:07 UTC by Aruna Sankaranarayanan
Modified: 2013-03-25 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixed all the bad links except the stubs (3.57 KB, patch)
2013-03-24 13:11 UTC, Aruna Sankaranarayanan
needs-work Details | Review
Fixed the stubs too (9.33 KB, patch)
2013-03-24 14:12 UTC, Aruna Sankaranarayanan
committed Details | Review
Fixed validation errors (1.46 KB, patch)
2013-03-25 17:10 UTC, Aruna Sankaranarayanan
none Details | Review

Description Aruna Sankaranarayanan 2013-03-24 13:07:32 UTC
Some links in gnome-help are not accessible.

Steps to reproduce:
yelp-check links *.page in gnome-user-docs/gnome-help/C

power-off, privacy-history,windows-key, display-dimscreen,a11y-locate-pointer
are the bad links.

display-dimscreen and a11y-locate-pointer are stubs, and that's why they appear as bad links. The pages with the other links have to be modified suitably.
Comment 1 Aruna Sankaranarayanan 2013-03-24 13:11:22 UTC
Created attachment 239675 [details] [review]
Fixed all the bad links except the stubs

I think the power-off was referring to power-turnoffbutton.page.old but the id there is power-turnoffbutton.

All links pointing to power-off have been redirected to shell-exit#shutdown. I commented out the Seealso link pointing to power-off right above shell-exit#shutdown.

Hope the patch's alright.

Thanks!
Comment 2 Kat 2013-03-24 13:26:31 UTC
Review of attachment 239675 [details] [review]:

Fix the rest of the links problems in the same commit:
a11y-contrast: display-dimscreen
a11y-contrast: display-dimscreen
keyboard-cursor-blink: a11y-locate-pointer
power-batterylife: display-dimscreen
power-batterylife: display-dimscreen
power-batterylife: display-dimscreen
prefs-display: display-dimscreen
Comment 3 Aruna Sankaranarayanan 2013-03-24 14:12:35 UTC
Created attachment 239677 [details] [review]
Fixed the stubs too

Fixed all the bad links by quoting out references to display-dimscreen and adding the seealso links to the stubs.

Will fix validation errors in another patch and submit!

Thanks!
Comment 4 Kat 2013-03-24 19:19:28 UTC
Comment on attachment 239677 [details] [review]
Fixed the stubs too

Pushed to master in commit a7640e0d9bab034b6cf5bf284461cf6eb939b579
Comment 5 Aruna Sankaranarayanan 2013-03-25 17:10:55 UTC
Created attachment 239793 [details] [review]
Fixed validation errors

Validation errors because of <src> tags in nautilus-behaviour.page.
Changed all <src> tags to <sys> tags.

Thanks!
Comment 6 Aruna Sankaranarayanan 2013-03-25 17:17:14 UTC
Comment on attachment 239793 [details] [review]
Fixed validation errors

Wrong bug.