GNOME Bugzilla – Bug 696489
Add test to validate .desktop files
Last modified: 2021-06-05 16:29:52 UTC
As discussed on gnome-i18n, it would be useful if there was a pre-receive hook to prevent translators pushing commits which break .desktop files. This hook could use desktop-file-validate to check the .desktop files; similarly to how the existing pre-receive-check-po script uses msgfmt to check .po files.
It also would be useful to check documnetation syntax with gtxml (https://launchpad.net/pyg3t) to avoid typos in documentation tags.
Two problems here:
- the desktop files we need to check are generated files, they don't actually exist in git. You'd have to build to get them
- the desktop-file-validate has to be reasonably new. The version that is in rhel5 or rhel6 almost certainly won't do
(In reply to comment #2)
> - the desktop files we need to check are generated files, they don't actually
> exist in git. You'd have to build to get them
Hmm, that’s a pain. It might be possible to run intltool-merge on the git tree and generate the .desktop files in a temporary directory from the hook; i.e. run the @INTLTOOL_DESKTOP_RULE@ code in the hook.
The GNOME Infrastructure Team is currently migrating its bug / issue tracker away from Bugzilla to Request Tracker and therefore all the currently open bugs have been closed and marked as OBSOLETE.
The following move will also act as a cleanup for very old and ancient tickets that were still living on Bugzilla. If your issue still hasn't been fixed as of today please report it again on the relevant RT queue.
More details about the available queues you can report the bug against can be found at https://wiki.gnome.org/Sysadmin/RequestTracker.
Thanks for your patience,
the GNOME Infrastructure Team
*** Bug 723138 has been marked as a duplicate of this bug. ***
I added a imperfect pre-commit hook to git.gnome.org as part of bug 723138 (unduped it). I think this is a perfect thing that could be integrated with gnome-continuous.
gnome-continuous is not under active development anymore. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-continuous
Closing all its open tickets as part of housekeeping.