After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696466 - Inverted logic when testing for empty 'set state'
Inverted logic when testing for empty 'set state'
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
2.7.x
Other All
: Normal minor
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-23 19:10 UTC by John E
Modified: 2013-03-27 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Invert (i.e. correct) the testing logic in 'atk/tests/teststateset.c' (784 bytes, patch)
2013-03-23 19:10 UTC, John E 		committed Details | Review

Description John E 2013-03-23 19:10:45 UTC 
Created attachment 239640 [details] [review]
Invert (i.e. correct) the testing logic in 'atk/tests/teststateset.c'

In 'atk/atkstateset.c' the function 'atk_state_set_is_empty()' returns TRUE if the state set is empty and FALSE otherwise. This means that in 'atk/tests/teststateset.c' the comparison logic is the wrong way around at lines 37 and 51. I believe these tests are outdated now, so it's not urgent but they might as well be right.

The attached patch corrects the accidentally inverse logic.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-03-27 14:48:30 UTC 
(In reply to comment #0)

> 
> The attached patch corrects the accidentally inverse logic.

Patch committed. Closing bug. Thanks.