After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696432 - Click open calendar -> evolution mail starts
Click open calendar -> evolution mail starts
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-23 03:08 UTC by sangu
Modified: 2013-03-25 09:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dateMenu: Re-add special-casing of evolution-calendar (1.04 KB, patch)
2013-03-23 08:38 UTC, Florian Müllner 		committed Details | Review

Description sangu 2013-03-23 03:08:45 UTC 
Click open calendar -> evolution mail starts

evolution-3.7.92-1.fc19.x86_64
gnome-shell-3.7.92-2.fc19.x86_64
Comment 1 Florian Müllner 2013-03-23 08:38:50 UTC 
Created attachment 239616 [details] [review]
dateMenu: Re-add special-casing of evolution-calendar

When commit 724a2bd7 changed the way to determine the default
calendar app, it dropped all special handling of evolution.
Unfortunately we still need it to not end up with the default
mail component, so add it back.
Comment 2 drago01 2013-03-23 09:11:26 UTC 
Review of attachment 239616 [details] [review]:

Looks good, maybe worth a freeze break (not critical but low impact).
Comment 3 Giovanni Campagna 2013-03-23 12:52:59 UTC 
No, this is wrong.
If evolution-calendar.desktop exists, that's the one that should expose text/calendar, and evolution.desktop should handle mail mime types only.
Comment 4 Florian Müllner 2013-03-23 13:18:25 UTC 
(In reply to comment #3)
> No, this is wrong.

No, it's not, it's just not ideal - evolution-calendar.desktop is a workaround *we* added (it's in src/calendar-server) to support startup notifications for the "Open Calendar" item. The evolution developers rejected the .desktop file for evolution, so I doubt they'll be willing to drop the mime type from their .desktop file.
If you can convince the evolution developers to change their mind - fine. But a workaround not being the best solution possible is not an excuse for breaking behavior for users.
Comment 5 Giovanni Campagna 2013-03-23 13:27:53 UTC 
What? We ship evolution-calendar.desktop?
Oh, this is really sad...
Comment 6 Florian Müllner 2013-03-23 13:33:02 UTC 
Yes, I would have been a lot happier to have it in evolution.
Comment 7 Matthias Clasen 2013-03-24 03:45:59 UTC 
I think we should take this as a regression fix for 3.8.0
Comment 8 Florian Müllner 2013-03-25 09:46:02 UTC 
Pushing after r-t approval

Attachment 239616 [details] pushed as 390491b - dateMenu: Re-add special-casing of evolution-calendar