After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696422 - dash: Dismissing context menu may activate window
dash: Dismissing context menu may activate window
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 694193 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-22 20:31 UTC by Florian Müllner
Modified: 2013-09-07 01:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grabHelper: Consider events that release the grab handled (1.18 KB, patch)
2013-03-22 20:31 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-03-22 20:31:32 UTC 
This was fixed in bug 661151, but the port to grabHelper brought it back:

 - right click dash item
 - click on a preview in the window picker
 => button press dismisses the menu (expected),
    button release activates the window (unexpected)

The cause is that grabHelper ungrabs() on ButtonPress, and then let the emission of the same event continue. See patch.
Comment 1 Florian Müllner 2013-03-22 20:31:34 UTC 
Created attachment 239576 [details] [review]
grabHelper: Consider events that release the grab handled

Currently, if a button-press event results in releasing the last modal
grab (e.g. clicks outside the grabbed actors), we don't consider the
event handled and allow its emission to continue. If we consider
dismissing a grab as an action of its own, any additional action
triggered by the same event becomes an unexpected side effect.
Tweak the capture handler accordingly.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-22 20:34:58 UTC 
Review of attachment 239576 [details] [review]:

Looks correct. Up to you if this constitutes freeze break or not.
Comment 3 Florian Müllner 2013-03-25 09:45:02 UTC 
Pushing after r-t approval.

Attachment 239576 [details] pushed as f8ea825 - grabHelper: Consider events that release the grab handled
Comment 4 Florian Müllner 2013-09-07 01:58:12 UTC 
*** Bug 694193 has been marked as a duplicate of this bug. ***