After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696367 - devhelp's gschema crashes gsettings tool
devhelp's gschema crashes gsettings tool
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
3.7.x
Other Linux
: High critical
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-22 08:11 UTC by Jiro Matsuzawa
Modified: 2013-03-25 06:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gschema: rename child to correspond to its path (1023 bytes, patch)
2013-03-22 08:18 UTC, Jiro Matsuzawa
none Details | Review
Change the fonts path and also fix the convert-file. (1.65 KB, patch)
2013-03-23 12:59 UTC, Thomas Bechtold
committed Details | Review

Description Jiro Matsuzawa 2013-03-22 08:11:21 UTC
Problem
=======

The gsettings tool crashes when it reads the devhelp gschema.


How to Reproduce
================

% gsettings list-children org.gnome.devhelp
state   org.gnome.devhelp.state

(process:21441): GLib-GIO-ERROR **: settings object created with schema 'org.gnome.devhelp.fonts' and path '/org/gnome/devhelp/ui/', but path '/org/gnome/devhelp/fonts/' is specified by schema
zsh: trace trap (core dumped)  gsettings list-children org.gnome.devhelp


% gsettings list-recursively
org.gnome.gthumb.pixbuf-savers.jpeg default-ext 'jpeg'
(...snip...)
org.gnome.clocks world-clocks @aa{sv} []
org.gnome.devhelp.state.assistant.window height 400
org.gnome.devhelp.state.assistant.window width 350
org.gnome.devhelp.state.assistant.window x-position 0
org.gnome.devhelp.state.assistant.window y-position 0
org.gnome.devhelp.state.main.contents books-disabled @as []
org.gnome.devhelp.state.main.contents group-books-by-language false
org.gnome.devhelp.state.main.paned position 250
org.gnome.devhelp.state.main.search-notebook selected-tab 'content'
org.gnome.devhelp.state.main.window height 500
org.gnome.devhelp.state.main.window maximized false
org.gnome.devhelp.state.main.window width 700
org.gnome.devhelp.state.main.window x-position 100
org.gnome.devhelp.state.main.window y-position 100

(process:24684): GLib-GIO-ERROR **: settings object created with schema 'org.gnome.devhelp.fonts' and path '/org/gnome/devhelp/ui/', but path '/org/gnome/devhelp/fonts/' is specified by schema
zsh: trace trap (core dumped)  gsettings list-recursively


Brack Trace
===========

% gdb -q gsettings -c core
Reading symbols from /opt/gnome/install/bin/gsettings...done.
[New LWP 21441]
[New LWP 21442]

warning: Can't read pathname for load map: Input/output error.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `gsettings list-children org.gnome.devhelp'.
Program terminated with signal 5, Trace/breakpoint trap.
  • #0 g_logv
    at gmessages.c line 981
  • #0 g_logv
    at gmessages.c line 981
  • #1 g_log
    at gmessages.c line 1010
  • #2 g_settings_constructed
    at gsettings.c line 566
  • #3 g_object_newv
    at gobject.c line 1747
  • #4 g_object_new_valist
    at gobject.c line 1836
  • #5 g_object_new
    at gobject.c line 1551
  • #6 g_settings_get_child
    at gsettings.c line 2087
  • #7 gsettings_list_children
    at gsettings-tool.c line 199
  • #8 main
    at gsettings-tool.c line 824

Comment 1 Jiro Matsuzawa 2013-03-22 08:18:48 UTC
Created attachment 239518 [details] [review]
gschema: rename child to correspond to its path

I changed the name attribute of the child schema "org.gnome.devhelp.fonts". It seems that a name of child schemas should correspond to its path. The path of the schema "org.gnome.devhelp.fonts" is "/org/gnome/devhelp/fonts/". Its name needs to be "fonts" not "ui".
Comment 2 Aleksander Morgado 2013-03-22 08:28:05 UTC
Might be worth to also change data/devhelp.convert to use 'fonts' instead of 'ui' in the elements within [org.gnome.devhelp.fonts].

And also change the code accordingly, of course.

Thomas, what do you think?
Comment 3 Thomas Bechtold 2013-03-23 12:58:11 UTC
(In reply to comment #2)
> Might be worth to also change data/devhelp.convert to use 'fonts' instead of
> 'ui' in the elements within [org.gnome.devhelp.fonts].

yes. I extended the patch and also changed the convert-file.

> And also change the code accordingly, of course.

I guess there's no code we have to change.
Comment 4 Thomas Bechtold 2013-03-23 12:59:13 UTC
Created attachment 239627 [details] [review]
Change the fonts path and also fix the convert-file.
Comment 5 Aleksander Morgado 2013-03-24 22:50:28 UTC
Review of attachment 239627 [details] [review]:

Looks good to me.
Comment 6 Frederic Peters 2013-03-25 06:28:27 UTC
Thanks, just in time for 3.8.