After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696366 - When quitting with ctrl + q, save dialog do not popup
When quitting with ctrl + q, save dialog do not popup
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-22 06:56 UTC by sangu
Modified: 2013-03-22 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
quit (1.41 KB, patch)
2013-03-22 07:59 UTC, Ignacio Casal Quinteiro (nacho) 		reviewed Details | Review
quit2 (779 bytes, patch)
2013-03-22 10:08 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
quit3 (1.40 KB, patch)
2013-03-22 10:27 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review

Description sangu 2013-03-22 06:56:34 UTC 
When quitting with ctrl + q, save dialog do not popup

1. launch gedit
2. type in gedit
3. TEST
* ctrL + w 
 popup save dialog 
* click close button
 popup save dialog 
* click close in menu
 popup save dialog
* click ctrl + q
Quit gedit

gedit-3.7.6-1.fc19.x86_64
gtk3-3.7.14-1.fc19.x86_64
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-03-22 07:59:07 UTC 
Created attachment 239517 [details] [review]
quit

So it seems we forgot to implement that codepath :) here it is the patch that should fix it.
Comment 2 Matthias Clasen 2013-03-22 09:48:49 UTC 
Review of attachment 239517 [details] [review]:

::: gedit/gedit-commands-file.c
@@ +1962,1 @@
 	{

This looks fishy to me - why would you have a different condition on OS X  ? The callers are not ifdefed (at least the one you're adding in this patch isn't and it passes NULL for both arguments, meaning that it will behave differently on OS X...
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-03-22 09:56:56 UTC 
I didn't want to touch the condition for OSX mainly 'cause not sure how it works the app menu there. (this is up to jesse to keep it or fix it)

Also I wanted to keep the previous behaviour of quitting for the case gedit does not run on gnome-shell, meaning that in that specific case a window parameter is passed.

dunno...
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-03-22 10:08:55 UTC 
Created attachment 239522 [details] [review]
quit2

Removed that ifdef, if it is needed on OSX we can fix it later. OSX is broken right now anyway...
Comment 5 Matthias Clasen 2013-03-22 10:25:10 UTC 
Thats a different patch...
Comment 6 Ignacio Casal Quinteiro (nacho) 2013-03-22 10:27:50 UTC 
Created attachment 239529 [details] [review]
quit3

urgh... sorry about that
Comment 7 Ignacio Casal Quinteiro (nacho) 2013-03-22 11:09:48 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.