After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696301 - [WK2] Reload/stop button is not in sync with the load
[WK2] Reload/stop button is not in sync with the load
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-21 15:53 UTC by Xan Lopez
Modified: 2013-03-21 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
reload-stop.diff (2.38 KB, patch)
2013-03-21 16:03 UTC, Xan Lopez 		committed Details | Review

Description Xan Lopez 2013-03-21 15:53:43 UTC 
We basically never ported this.
Comment 1 Xan Lopez 2013-03-21 16:03:26 UTC 
Created attachment 239477 [details] [review]
reload-stop.diff
Comment 2 Carlos Garcia Campos 2013-03-21 16:14:50 UTC 
Review of attachment 239477 [details] [review]:

oops, it seems I missed that. Patch looks good to me, thanks!

::: src/ephy-window.c
@@ +2757,3 @@
 	sync_tab_document_type	(view, NULL, window);
+#ifdef HAVE_WEBKIT2
+	sync_tab_load_status (ephy_embed_get_web_view (embed), WEBKIT_LOAD_STARTED, window);

I guess you can use the view here directly instead of ephy_embed_get_web_view (embed)
Comment 3 Xan Lopez 2013-03-21 17:16:48 UTC 
Thanks, pushed with that change to master and gnome-3-8.