After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696285 - ownCloud: Check addressbook even if calendar fails
ownCloud: Check addressbook even if calendar fails
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Reported: 2013-03-21 13:16 UTC by Vadim Rutkovsky
Modified: 2013-09-14 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

owncloud: owncloud: try to add addressbook even if calendar has failed (2.05 KB, patch)
2013-03-22 13:29 UTC, Vadim Rutkovsky
reviewed Details | Review

Description Vadim Rutkovsky 2013-03-21 13:16:51 UTC
After configuring owncloud's addressbook (I used, new addressbook was not created (calendar did appear)

Comment 1 Milan Crha 2013-03-22 11:17:55 UTC
Thanks for a bug report. The last time I tried, my server was not responding that quickly on https with addressbook, while calendar responded fine. Thus I guess the evolution-source-registry is waiting for a response from the server, or something failed.

Could you run the source registry from a console, and check its output, please? There is no extra debugging available for the ownCloud module, but if you run the source registry also under gdb, and place a breakpoint into owncloud_utils_search_server(), then you might see two calls to find_sources(), the first is for calendar sources, while the second for addressbook. Please check what the find_sources() does for 'addressbooks'.

Feel free to ping me on IRC, if you'll need more detailed guidance.
Comment 2 Vadim Rutkovsky 2013-03-22 12:51:18 UTC
Happens on, as they have disabled listing of available addressbooks due to owncloud 5.0RC2 bug, will verify on previous versions
Comment 3 Vadim Rutkovsky 2013-03-22 13:29:43 UTC
Created attachment 239540 [details] [review]
owncloud: owncloud: try to add addressbook even if calendar has  failed

Keeping the issue open as all owncloud since 5.0 are affected (especially the most popular one -, however this is not e-d-s fault.

Meanwhile, the attached patch improves owncloud instance handling - calendar might not be added due to some reason and this should not block creation of new addressbooks
Comment 4 Milan Crha 2013-03-25 13:00:45 UTC
Review of attachment 239540 [details] [review]:

Apart of the one thing looks good. Please commit to gnome-3-8 and master, after you'll change that. Thanks.

::: modules/owncloud-backend/owncloud-utils.c
@@ +636,3 @@
 	gchar *url;
+	gboolean res_calendars = TRUE;
+	gboolean res_contacts = TRUE;

You changed logic of this a bit, thus I would change the default values to FALSE instead.
Comment 5 Vadim Rutkovsky 2013-03-25 13:09:24 UTC
Committed 141144a5 to master
Committed 7cee41f4 to gnome-3-8