GNOME Bugzilla – Bug 696236
Weekdays/Weekends definition should be localized
Last modified: 2021-06-01 22:44:30 UTC
See patch
Created attachment 239419 [details] [review] Add "Weekends" label for alarms set to Sat and Sun Clocks already has a similiar behavior for alarms set to "Weekdays"/"Every Day".
You are hardcoding that in your culture the weekend is Saturday and Sunday? That's quite unI18Nanble...
(In reply to comment #2) > You are hardcoding that in your culture the weekend is Saturday and Sunday? > That's quite unI18Nanble... In the same way that is already hardcoded that weekedays are not Saturday and not Sunday :-) I got your point, André. But to cover what you're expecting Clocks should provide a way to set Weekdays/Weekends and it's not related to this patch (in my point of view). Paolo, do you want to have this behavior in Clocks?
(In reply to comment #3) > In the same way that is already hardcoded that weekedays are not Saturday > and not Sunday :-) Sure, I can file another bug report about that. :) > But to cover what you're expecting Clocks should provide a way to set > Weekdays/Weekends and it's not related to this patch (in my point of view). Probably *GNOME* should provide a way to set weekdays/weekends (yeah, different request and way more complex), as Clocks is not the only app for this (e.g. Evolution provides a [rather crappy] UI for this under "Calendar Preferences"). Still I don't see how hardcoding helps anybody here. GSettings at least? :-/
I think we should investigate if we can get the information about which ones are the "week days" and which days are "weekend" from the libc localization information. This is a separate bug and I would appreciate a bugreport about that. In the mean time using the "weekends" sounds good to me
nl_langinfo should be able to give you that information, with _NL_TIME_FIRST_WORKDAY
(In reply to comment #5) > I think we should investigate if we can get the information about which ones > are the "week days" and which days are "weekend" from the libc localization > information. This is a separate bug and I would appreciate a bugreport about > that. > > > In the mean time using the "weekends" sounds good to me Could I push? :-)
> > Could I push? :-) I am planning to branch after 3.8.1 so it has to wait a few more days. Maybe while you wait you could give _NL_TIME_FIRST_WORKDAY a shot :P
I applied Fabiano's patch for 3.9.1. Retitling the bug for the localization issue
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-clocks/-/issues/ Thank you for your understanding and your help.