After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696227 - gnome-commander fails to build with libgsf 1.14.26
gnome-commander fails to build with libgsf 1.14.26
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: metadata-tags
unspecified
Other Linux
: High critical
: 1.4
Assigned To: GNOME Commander maintainer(s)
epiotr
Depends on:
Blocks:
 
 
Reported: 2013-03-20 21:30 UTC by Dominique Leuenberger
Modified: 2014-01-08 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Detect and support libgsf 1.14.26 (1.38 KB, patch)
2013-03-20 21:31 UTC, Dominique Leuenberger
none Details | Review

Description Dominique Leuenberger 2013-03-20 21:30:53 UTC
libgsf 1.14.26 changed the header layout and is now a one-header include library.

gnome-commander fails to build with:

[  794s] gnome-cmd-tags-doc.cc: In function 'void process_metadata(gpointer, gpointer, gpointer)':
[  794s] gnome-cmd-tags-doc.cc:198:52: error: 'gsf_doc_prop_get_val' was not declared in this scope
[  794s] gnome-cmd-tags-doc.cc: In function 'void process_opendoc_infile(GsfInfile*, GnomeCmdFileMetadata*)':
[  794s] gnome-cmd-tags-doc.cc:250:55: error: 'gsf_doc_meta_data_new' was not declared in this scope
[  794s] gnome-cmd-tags-doc.cc:251:27: warning: 'GError* gsf_opendoc_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-opendoc-utils.h:149): Use 'gsf_doc_meta_data_read_from_odf' instead [-Wdeprecated-declarations]
[  794s] gnome-cmd-tags-doc.cc:251:73: warning: 'GError* gsf_opendoc_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-opendoc-utils.h:149): Use 'gsf_doc_meta_data_read_from_odf' instead [-Wdeprecated-declarations]
[  794s] gnome-cmd-tags-doc.cc:254:73: error: 'gsf_doc_meta_data_foreach' was not declared in this scope
[  794s] gnome-cmd-tags-doc.cc: In function 'void process_msole_summary(GsfInput*, GnomeCmdFileMetadata*)':
[  794s] gnome-cmd-tags-doc.cc:264:55: error: 'gsf_doc_meta_data_new' was not declared in this scope
[  794s] gnome-cmd-tags-doc.cc:265:27: warning: 'GError* gsf_msole_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-msole-utils.h:37): Use 'gsf_doc_meta_data_read_from_msole' instead [-Wdeprecated-declarations]
[  794s] gnome-cmd-tags-doc.cc:265:67: warning: 'GError* gsf_msole_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-msole-utils.h:37): Use 'gsf_doc_meta_data_read_from_msole' instead [-Wdeprecated-declarations]
[  794s] gnome-cmd-tags-doc.cc:268:73: error: 'gsf_doc_meta_data_foreach' was not declared in this scope
[  794s] gnome-cmd-tags.cc: In member function 'void GnomeCmdFileMetadata::addf(GnomeCmdTag, const gchar*, ...)':
[  794s] gnome-cmd-tags.cc:94:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Comment 1 Dominique Leuenberger 2013-03-20 21:31:51 UTC
Created attachment 239410 [details] [review]
Detect and support libgsf 1.14.26
Comment 2 Dominique Leuenberger 2013-12-23 19:53:23 UTC
Seems that had been addressed in 'some' way in newer versions...

Would be more future proof to really only include the main header; just as for glib and other libs.
Comment 3 Uwe Scholz 2014-01-08 10:23:07 UTC
Thank you! I have seen your bug report just recently. The patch is applied in the current master branch and fixes my previous (not so clean) solution.