Created attachment 239408 [details] [review]
Complete _gdk_wayland_display_get_cursor_for_pixbuf

Works well for gnome-robots. The cursor hotspots seems to be a bit off but I suspect that it could be related to bug #695512

Also works for aisleriot.

Review of attachment 239408 [details] [review]:

Tested the patch and it work fine here.  Should be good to commit with the comments below addressed.

::: gdk/wayland/gdkcursor-wayland.c
@@ +215,3 @@
 					cursor->height,
+                    stride,
+                    WL_SHM_FORMAT_ARGB8888);

Funky indentation here...

We can and should destroy the pool object right after creating the wl_buffer from it.  Also, wl_buffers from the cursor theme are owned by the theme and doesn't need to be freed.  In case of a cursor created from a pixbuf (type == GDK_CURSOR_IS_PIXMAP), we own the wl_buffer and need to destroy it (wl_buffer_destroy) in finalize.

Also, I'd fold create_cursor into _gdk_wayland_display_get_cursor_for_pixbuf at this point.

Created attachment 239497 [details] [review]
updated patch for comments

Thanks, pushed as:

commit c5145421af3e641b3070bba2a83d3c2f74a06f53
Author: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date:   Thu Mar 21 21:05:32 2013 +0100

    wayland: complete cursor_for_pixbuf
    
    Finishes the implementation for loading cursors from pixbufs.
    
    Gnome bug #696223