After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696166 - have lock screen curtain background configurable
have lock screen curtain background configurable
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.10
: 673195 (view as bug list)
Depends on: 688210
Blocks:
 
 
Reported: 2013-03-19 23:17 UTC by Jakub Steiner
Modified: 2014-08-19 21:30 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
background: Remove unused "lock" preview widgets (5.54 KB, patch)
2013-08-19 20:28 UTC, Bastien Nocera 		committed Details | Review
background: Add support for lock screen background (33.62 KB, patch)
2013-08-19 20:30 UTC, Bastien Nocera 		none Details | Review
background: Fix memory corruption when creating preview (1.47 KB, patch)
2013-08-19 21:46 UTC, Bastien Nocera 		committed Details | Review
background: Add support for lock screen background (36.45 KB, patch)
2013-08-19 22:35 UTC, Bastien Nocera 		committed Details | Review

Description Jakub Steiner 2013-03-19 23:17:05 UTC 
The background panel should have two buttons to configure the backgrounds of both the user session wallpaper and the lock screen curtain:

https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/wallpaper/with-lock-screen.png
Comment 1 Giovanni Campagna 2013-06-10 19:58:00 UTC 
Mh!

Technical issue: how do you make a screenshot of the lock screen, without showing it?
Comment 2 Bastien Nocera 2013-06-11 10:05:01 UTC 
Hmm. That's going to make it a tad more complicated... I'm already not very happy with having to hack the normal desktop rendering (which expects to have a single panel for example).
Comment 3 Matthias Clasen 2013-08-13 16:46:27 UTC 
Putting this on 3.10 blocker list at Allan's request. But without somebody actively working on this, we'll end up dropping it again...
Comment 4 Bastien Nocera 2013-08-19 20:28:40 UTC 
Created attachment 252285 [details] [review]
background: Remove unused "lock" preview widgets
Comment 5 Bastien Nocera 2013-08-19 20:30:39 UTC 
Created attachment 252286 [details] [review]
background: Add support for lock screen background
Comment 6 Bastien Nocera 2013-08-19 20:32:55 UTC 
(In reply to comment #1)
> Mh!
> 
> Technical issue: how do you make a screenshot of the lock screen, without
> showing it?

The patches above don't have a proper preview for the lock screen, unfortunately, but it's better than nothing. We should really have a proper API in gnome-shell to create the previews, instead of us doing it by hand.

Currently chasing a corruption in the previews. The code could also do with a cleanup post-3.10 (or during the UI freeze).
Comment 7 Bastien Nocera 2013-08-19 21:46:59 UTC 
Created attachment 252300 [details] [review]
background: Fix memory corruption when creating preview

When using a single screen, the captured area was too small, and
we were copying data from out-of-bounds of the pixbuf area.
Comment 8 Bastien Nocera 2013-08-19 22:35:05 UTC 
Created attachment 252310 [details] [review]
background: Add support for lock screen background
Comment 9 Bastien Nocera 2013-08-19 22:38:25 UTC 
Attachment 252285 [details] pushed as ea16cad - background: Remove unused "lock" preview widgets
Attachment 252300 [details] pushed as 1097d4c - background: Fix memory corruption when creating preview
Attachment 252310 [details] pushed as 074f55e - background: Add support for lock screen background
Comment 10 Bastien Nocera 2013-09-07 22:10:29 UTC 
Pushed to gnome-3-8 as well.
Comment 11 Bastien Nocera 2014-08-19 21:30:15 UTC 
*** Bug 673195 has been marked as a duplicate of this bug. ***