After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696152 - Register to Treeview - Dupe and Reverse trans
Register to Treeview - Dupe and Reverse trans
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Register
2.5.x
Other Linux
: Normal enhancement
: ---
Assigned To: Christian Stimming
Geert Janssens
Depends on:
Blocks: 673193
 
 
Reported: 2013-03-19 17:17 UTC by Bob
Modified: 2018-06-29 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Register rewrite patch (76.24 KB, patch)
2013-03-19 17:17 UTC, Bob
committed Details | Review
Backtrace while duplicating a transaction (21.80 KB, text/plain)
2013-03-26 18:53 UTC, Geert Janssens
  Details

Description Bob 2013-03-19 17:17:05 UTC
Created attachment 239274 [details] [review]
Register rewrite patch

This is an update to the Possible Register migration to Treeview - 673193

As before, do not open same account register in old style and the tree-view one
and it may also be required to delete the saved pages in gconf under register2
heading.

This update fixes duplicate transaction and reversing transaction. Also included is a minor change to the model, added the test for unbalanced transactions along with some other dialogs. Tab key navigation has been revised but is still a work in progress. Account key separator works along with new account creation.
Comment 1 Geert Janssens 2013-03-26 18:52:30 UTC
Comment on attachment 239274 [details] [review]
Register rewrite patch

Thank you for the patch.

Unfortunately, for me gnucash crashes when I try to duplicate a transaction. I will attach a backtrace.

What I did:
- applied both of your latest patches (update11 and update12)
- run gnucash
- open an asset account
- click on one transaction
- hit the duplicate button in the toolbar
- leave the suggested date as is (shows 26.03.2013 in my example), leave the number field blank.
- click ok

=> Crash
Comment 2 Geert Janssens 2013-03-26 18:53:21 UTC
Created attachment 239890 [details]
Backtrace while duplicating a transaction
Comment 3 Bob 2013-03-29 19:26:21 UTC
Thank you for the back trace, it all pointed to some bad g_free's which pointed to an incorrect implementation of setting the num column entries when being duplicated. I have corrected this in the second patch on the latest bug 696868.
Comment 4 John Ralls 2013-04-07 22:21:37 UTC
Comment on attachment 239274 [details] [review]
Register rewrite patch

Committed with the rest, having confirmed that patch 14 fixed the crash.
Comment 5 Geert Janssens 2013-04-20 16:55:26 UTC
The crash is indeed fixed after the commit of bug 696868. Closing the report.
Comment 6 John Ralls 2018-06-29 23:14:21 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=696152. Please update any external references or bookmarks.