After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696123 - Patch: support 14 tabs with keyboard hotkeys
Patch: support 14 tabs with keyboard hotkeys
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: gnome-3-10
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-19 10:13 UTC by Ingo Molnar
Modified: 2013-04-02 21:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
extend gnome-terminal hotkeys to 14 tabs (2.86 KB, patch)
2013-03-19 10:13 UTC, Ingo Molnar
none Details | Review

Description Ingo Molnar 2013-03-19 10:13:32 UTC
Created attachment 239231 [details] [review]
extend gnome-terminal hotkeys to 14 tabs

I use a lot of terminal tabs, and my keyboard has 14 keys in the top row - all of which I'd like to use for tab switching.

gnome-terminal currently supports up to 12 tabs. The attached patch extends gnome-terminal support for keyboard tab-switching shotcuts from 12 to 14.

Tested on top of gnome-3-6 commit b99f49e3a302.
Comment 1 Christian Persch 2013-03-20 19:36:06 UTC
The patch didn't apply to master / 3.8 branch since that now uses GSettings instead of GConf; I've adapted it however and pushed the result to master.

Note that gnome 3.8 has already entered feature, UI & string freeze, so this cannot be added for gnome-terminal 3.8.

For the same reson, it's not possible to add this to 3.6; but you might want to lobby your favourite distro to include it (for 3.6 the patch as attached below should be used instead of what was actually committed to gnome git).
Comment 2 Ingo Molnar 2013-03-21 10:29:43 UTC
Thanks for adopting my patch to the devel code!

While I managed to build the latest version via jhbuild, I could not get it to run - so I had to write the patch for gnome-3.6.

Btw., just a quick (unsolicited) observation: it will now take up to 1-1.5 years for this trivial patch to reach me via a regular distro path. (I wouldn't call it a feature really.)

Lobbying each distro one by one does not scale.

Compare this to terminal emulators available on the Android app store: there, if the developer of the app agrees with a trivial enhancement and merges it, it will literally take a few hours (at most a few days) to push out a new change to users.

Not 300+ days. That's a two orders of magnitude difference...

Obviously that kind of release engineering flow and latency sucks to users and developers alike and stifles progress.

The Linux kernel had such teething problems about 10 years ago and it solved it mainly by switching to a 3 months release cycle. (and also relaxed the rules about what can be backported.)

You might want to lobby your Gnome co-maintainers to fix this ASAP! :-)

Thanks!
Comment 3 Christian Persch 2013-03-21 13:02:35 UTC
I think the most distros don't even update their gnome packages beyond the gnome 3.even.2 release, so even if I did put the patch into a 3.6.3 gnome-terminal release, it wouldn't be picked up by distros :-/

What I might be able to do is put this into 3.8.1, but sans the UI (i.e. you'd need to use dconf-editor to change the keys) and sans the translatable strings. That would probably make it into Fedora 19.
Comment 4 Christian Persch 2013-04-01 19:15:41 UTC
It's in 3.8.0.1.
Comment 5 Kalev Lember 2013-04-02 21:07:35 UTC
... and 3.8.0.1 has a Fedora 19 build now:

https://admin.fedoraproject.org/updates/gnome-terminal-3.8.0.1-1.fc19