After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696114 - g-s-d media keys uses G_DBUS_FLAGS_DO_NOT_AUTOSTART with well-known name
g-s-d media keys uses G_DBUS_FLAGS_DO_NOT_AUTOSTART with well-known name
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-19 01:34 UTC by Colin Walters
Modified: 2013-03-19 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-media-keys-Watch-for-shell-to-appear-before-creating.patch (5.60 KB, patch)
2013-03-19 03:24 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-03-19 01:34:39 UTC 
This causes a critical warning at every method call.  I don't think this code could have ever worked, at least on login.

Could be a regression from:

commit b0cee1df30b4945f524611f354ff164d4a383262
Author: Florian Müllner <fmuellner@gnome.org>
Date:   Thu Nov 15 17:41:24 2012 +0100
Comment 1 Colin Walters 2013-03-19 02:03:16 UTC 
So...gnome-shell doesn't provide a dbus service file.  It probably should - I can't think of another way out of this.
Comment 2 Colin Walters 2013-03-19 02:13:14 UTC 
g-s-d *could* use g_bus_watch_name().
Comment 3 Colin Walters 2013-03-19 03:24:59 UTC 
Created attachment 239216 [details] [review]
0001-media-keys-Watch-for-shell-to-appear-before-creating.patch
Comment 4 Colin Walters 2013-03-19 03:25:22 UTC 
Aaand back to g-s-d.
Comment 5 Bastien Nocera 2013-03-19 07:56:52 UTC 
Review of attachment 239216 [details] [review]:

Please commit to gnome-3-8 and master

::: plugins/media-keys/gsd-media-keys-manager.c
@@ +168,2 @@
         /* Shell stuff */
+        guint           name_owner_id;

line up the letters.

@@ +2310,1 @@
+        manager->priv->name_owner_id =

single line
Comment 6 Colin Walters 2013-03-19 14:06:45 UTC 
master: https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=922478ebb361d47eb9309cfdd15b01c6eaad2749

Will send a HCF break request.
Comment 7 Bastien Nocera 2013-03-19 14:39:52 UTC 
There's no hard code freeze, we haven't released 3.7.92.
Comment 8 Bastien Nocera 2013-03-19 14:48:06 UTC 
Pushed to gnome-3-8 too.