GNOME Bugzilla – Bug 696078
We need specific incognito/private mode styling
Last modified: 2014-01-11 16:38:46 UTC
Reusing the dark theme for private mode poses a few issues, giving poor example to other apps as to when to use it. We should aim to create a special styling for it.
Also, in some environments (e.g. Ubuntu Unity with its default Ambiance theme) there is no visually distinguished dark theme, and so incognito windows look just like ordinary windows. So I think they should certainly be distinguished in some other way. Just appending "(Private Browsing)" to the window title might be good enough (or at least a good start).
Adam, I think other themes should provide their own dark theme alternative if needed. If just adding "(Private Browsing)" to the window title is sufficient, then the color of the window doesn't matter -- it will still be indicated in the title. I think it would be bad design to differentiate the private window only with text in the titlebar, however. That's difficult to see at a glance, and it makes application switching more tedious when users have to scan through similar window labels to find "(Private Browsing)" so they can differentiate which window is which. Color is the most user-friendly way of differentiating the windows. I think the concern about "giving poor example to other apps" is overblown, but any color would work -- dark red, purple, striped, plaid.
OK. I've filed an Ubuntu bug for this at https://bugs.launchpad.net/ubuntu-gnome/+bug/1167070
Jakub, do you have anything particular in mind for this?
We could remain neutral grey, just slightly darker than the default Adwaita and perhaps with a watermark on the headerbar. I'll mock something up.
Created attachment 265134 [details] blue tint + watermark on incognito windows.
Created attachment 265189 [details] [review] Make incognito image a resource
Created attachment 265190 [details] [review] Use a custom style for incognito mode
This style is very beautiful! I just wondering if the eye in the toolbar, in RTL language need to be in the right side istean of the left side.
Review of attachment 265189 [details] [review]: Good.
Review of attachment 265190 [details] [review]: Looks good, except for that. Didn't test though, I hope you did! ::: src/ephy-window.c @@ +3207,3 @@ + if (app_mode == EPHY_EMBED_SHELL_MODE_INCOGNITO) { + gtk_style_context_add_class (gtk_widget_get_style_context (toolbar), "incognito-mode"); + } No need for brackets.
(In reply to comment #9) > This style is very beautiful! > > I just wondering if the eye in the toolbar, in RTL language > need to be in the right side istean of the left side. That's a good question, but I really have no idea of how the images affect RTL. What is your take?
Attachment 265189 [details] pushed as 2c5a06f - Make incognito image a resource Attachment 265190 [details] pushed as d0af7ce - Use a custom style for incognito mode
(In reply to comment #12) > (In reply to comment #9) > > This style is very beautiful! > > > > I just wondering if the eye in the toolbar, in RTL language > > need to be in the right side istean of the left side. > > That's a good question, but I really have no idea of how the images affect RTL. > What is your take? The image not need to change, just the place of the image need to be replaced. This mean - the same image, just instead of in the left side, in RTL in the right side.
I find this interesting. Since we don't rely on the dark theme for incognito mode anymore, is there a way for Epiphany to enforce the use of the light theme variant even if the user tweaked the global dark theme setting? In order to fix/workaround bug #695388 which in turn is a workaround for bug #602217