After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696007 - Regression: No accessible names or labels for search results
Regression: No accessible names or labels for search results
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-17 19:17 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-03-18 16:13 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
accessible-event listener (1.08 KB, text/x-python)
2013-03-17 19:17 UTC, Joanmarie Diggs (IRC: joanie)
  Details
searchDisplay: Label search result actors for accessibility (1.16 KB, patch)
2013-03-17 19:41 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
searchDisplay: Add an accessible name to the provider icon (911 bytes, patch)
2013-03-17 19:41 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-03-17 19:17:04 UTC
Created attachment 239070 [details]
accessible-event listener

Steps to reproduce (in gnome-shell master):

1. Launch the attached listener in a terminal
2. Press Alt+F1
3. Type a letter or two to get some search results
4. Arrow amongst the results

Expected: The listener would dump out objects that either have an accessible name or an accessible label.

Actual: The listener dumps out objects that lack a name and also lack accessible labels.

Impact: When you arrow amongst the search results, Orca presents each one as "push button" and users who are blind don't know what the results are.

This is a regression from gnome-shell 3.6 and seems limited to search results. Everything else continues to be named or labelled.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-03-17 19:41:52 UTC
Created attachment 239071 [details] [review]
searchDisplay: Label search result actors for accessibility
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-17 19:41:55 UTC
Created attachment 239072 [details] [review]
searchDisplay: Add an accessible name to the provider icon
Comment 3 Joanmarie Diggs (IRC: joanie) 2013-03-17 19:47:38 UTC
Just gave these a spin. Solves the problem. Yay!! :) (And thank you for the uber-fast fix Jasper.)
Comment 4 Joanmarie Diggs (IRC: joanie) 2013-03-17 21:35:16 UTC
I don't have Release Team super powers to set the target of this bug, but I really think this should be considered a blocker for 3.8. (Assuming Jasper is waiting for a review, is hesitant to commit it this close to code freeze, whatever....)
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-03-17 23:10:51 UTC
(In reply to comment #4)
> I don't have Release Team super powers to set the target of this bug, but I
> really think this should be considered a blocker for 3.8.

I agree. Done.

> (Assuming Jasper is
> waiting for a review, is hesitant to commit it this close to code freeze,
> whatever....)

FWIW, I think that those patches are relevant and safe enough for asking for a freeze break request if are not included due lack of time on the release of this monday.
Comment 6 drago01 2013-03-18 10:00:18 UTC
Review of attachment 239071 [details] [review]:

OK.
Comment 7 drago01 2013-03-18 10:00:41 UTC
Review of attachment 239072 [details] [review]:

OK.
Comment 8 Matthias Clasen 2013-03-18 10:21:12 UTC
I'll give my release team approval here.
Go for it
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-03-18 16:13:53 UTC
Attachment 239071 [details] pushed as 41cf447 - searchDisplay: Label search result actors for accessibility
Attachment 239072 [details] pushed as 46aa70a - searchDisplay: Add an accessible name to the provider icon