Created attachment 239053 [details] [review]
add the delete option for extensions from the user's home

Review of attachment 239053 [details] [review]:

Comments in line.

::: gtweak/tweaks/tweak_shell_extensions.py
@@ +55,3 @@
 
+        path = os.path.join(self._shell.EXTENSION_DIR,uuid)
+        if os.path.exists(path):

Check the extension type is PER_USER

@@ +85,3 @@
+        path = os.path.join(self._shell.EXTENSION_DIR, uuid)
+        if os.path.exists(path):
+            dialog = DeleteExtensionDialog(name)

No need to delete this yourself, add a uninstall_extension method to gshellwrapper.py. This should call the UninstallExtesion dbus method of gnome-shell.

You should not need to restart the shell if the extension is disabled first.

::: gtweak/widgets.py
@@ +369,3 @@
+        Gtk.MessageDialog.__init__(self,0,type=Gtk.MessageType.QUESTION,
+                                          buttons=Gtk.ButtonsType.YES_NO,
+                                   message_format=message)

No need to create a class for this. Just create the MessageDialog in the extension tweak.

Created attachment 239217 [details] [review]
fixed the uninstall extension method

Review of attachment 239217 [details] [review]:

Looks good, thanks for your work!

For the next version of the patch, please submit a new patch instead of one that applies on top of the old ones.

::: gtweak/gshellwrapper.py
@@ +158,3 @@
+    def uninstall_extension(self, uuid):
+        return self._proxy.proxy_extensions.UninstallExtension('(s)', uuid)
+

The uninstall method is present in 3.4, so add it there, and add a fallback dummy method to the base GnomeShell class for older/unknown versions.

Review of attachment 239217 [details] [review]:

Looks good, thanks for your work!

For the next version of the patch, please submit a new patch instead of one that applies on top of the old ones.

::: gtweak/gshellwrapper.py
@@ +158,3 @@
+    def uninstall_extension(self, uuid):
+        return self._proxy.proxy_extensions.UninstallExtension('(s)', uuid)
+

The uninstall method is present in 3.4, so add it there, and add a fallback dummy method to the base GnomeShell class for older/unknown versions.

Created attachment 239435 [details] [review]
add the delete option for extensions from the user's home

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

*** Bug 672142 has been marked as a duplicate of this bug. ***

This is NOT fixed. In the Tweak Tool, I have grayed out box for remove button on almost all extensions. Some of them are not greyed, when I try to remove them all extensios get turned off, and I can turn them back on. But attempted removal of extension does not work. It is still there.

OS is Fedora 26.

Mihajlo, it's usually a better idea to open new bugs than to try to comment on a bug that was closed almost 5 years ago.

In GNOME Tweaks 3.26, installing and uninstalling extensions has been removed. Please use the GNOME Software app to install or uninstall extensions now.

Well, it does not remove extensions in GNOME Software either. My desktop is pretty unstable due to some extension, but can't remove any of them. It is updated from fedora 24 then 25 then 26. So this is probably why I still have old features