GNOME Bugzilla – Bug 695972
gdl_dock_object_set_stock_id does not update gdl-icon
Last modified: 2013-04-13 09:46:58 UTC
The latest gdl-3.0-vapi change introduce the regression that the gdl-icon does not update when stock_id is changed. Current (not working): public void get_stock_id (string stock_id); public void set_stock_id (string stock_id); public string stock_id { get; set construct; } Will result in e.g.: -> gdl_dock_object_set_stock_id ((GdlDockObject*) _tmp0_, GTK_STOCK_NEW); Old (works): [NoAccessorMethod] public string stock_id { owned get; set construct; } Will result in e.g.: -> g_object_set ((GdlDockObject*) _tmp0_, "stock-id", GTK_STOCK_NEW, NULL); To reproduce this issue one can use the gdl-example and change the stock-id of one DockItem after initialization: https://live.gnome.org/Vala/GdlSample I guess the same issue exists with DockObject.pixbuf_icon.
Created attachment 239052 [details] [review] dock-object: emit notify signal in setters I think it would be better to resolve this by fixing gdl, which is what this patch does. To work around this in Vala you can do foo.set ("stock-id", Gtk.Stock.NEW)
Thank you! I can confirm both the gdl patch and also the Vala workaround works.
Review of attachment 239052 [details] [review]: Thank you very much for your patch. GDL is part of GNOME which is currently in hard freeze period so I think it's better to commit this in the master branch after the release of the version 3.8 beginning of next week.
I have just committed your patch. Thank.